Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[barefoot] Fix y_profile_set to not reset link #6238

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

msosyak
Copy link
Contributor

@msosyak msosyak commented Dec 17, 2020

For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used.

- Why I did it
To be able to set another Y profile

- How I did it
Extend logic to check if the Y profile is already used
- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@msosyak
Copy link
Contributor Author

msosyak commented Dec 17, 2020

@akokhan @vboykox Please review

@msosyak msosyak changed the title Fix y_profile_set to not reset link [barefoot] Fix y_profile_set to not reset link Dec 17, 2020
@msosyak
Copy link
Contributor Author

msosyak commented Dec 17, 2020

retest vsimage please

@msosyak
Copy link
Contributor Author

msosyak commented Dec 18, 2020

retest mellanox please

@msosyak
Copy link
Contributor Author

msosyak commented Dec 18, 2020

@lguohan merge this, please

@lguohan
Copy link
Collaborator

lguohan commented Dec 20, 2020

can you explain y profile?

@msosyak
Copy link
Contributor Author

msosyak commented Dec 22, 2020

can you explain y profile?

Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation.

@msosyak
Copy link
Contributor Author

msosyak commented Dec 24, 2020

@lguohan could we merge this?

@lguohan lguohan merged commit f6d1c4a into sonic-net:master Dec 24, 2020
msosyak added a commit to msosyak/sonic-buildimage that referenced this pull request Dec 28, 2020
Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation.

For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used.
msosyak added a commit to msosyak/sonic-buildimage that referenced this pull request Mar 29, 2022
Y* profile is the name pattern for p4 programs that developed for the current platform. The difference between them is features enabled and resource reservation.

For this platform, it is expected to work on any Y profile. but after the latest changes, the first Y profile is always used.

Signed-off-by: Myron Sosyak <myronx.sosyak@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants