[device/accton] As7816-64x, fix memory leakage on accton fan monitor. #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
Dec 10, 2020
platform/broadcom/sonic-platform-modules-accton/as7816-64x/utils/accton_as7816_monitor.py
Outdated
Show resolved
Hide resolved
Signed-off-by: roy_lee <roy_lee@edge-core.com>
roylee123
force-pushed
the
as7816_fanmon_memory_raise
branch
from
5655817
to
c0fd04f
Compare
|
retest vsimage please |
lguohan
approved these changes
Dec 18, 2020
jleveque
approved these changes
Dec 18, 2020
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
#6168) It's been reported that accton fan monitor process keeps consuming memory after few days. The amount of memory occupied increases in linear and never leased. Signed-off-by: roy_lee <roy_lee@edge-core.com>
4 tasks
abdosi
pushed a commit
that referenced
this pull request
Feb 19, 2021
#6168) It's been reported that accton fan monitor process keeps consuming memory after few days. The amount of memory occupied increases in linear and never leased. Signed-off-by: roy_lee <roy_lee@edge-core.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: roy_lee roy_lee@edge-core.com
- Why I did it
It's been reported that accton fan monitor process keeps consuming memory after few days.
The amount of memory occupied increases in linear and never leased.
- How I did it
Just move declaration of thermal and fan object outside the loop.
- How to verify it
Just put in on for more than 5 days, check if the memory of accton fan montor increases.
- Description for the changelog
Just move declaration of thermal and fan object outside the loop.