Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sudoers] Add sonic-installer list to read-only commands #4996

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[sudoers] Add sonic-installer list to read-only commands #4996

merged 1 commit into from
Jul 20, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Jul 17, 2020 •
edited
Loading

sonic-installer list is a read-only command. Specify it as such in the sudoers file.

This will also ensure the new show boot command, which calls sudo sonic-installer list under the hood doesn't fail due to permissions.

@jleveque jleveque self-assigned this Jul 17, 2020
@jleveque jleveque mentioned this pull request Jul 17, 2020
Open
@jleveque
Copy link
Contributor Author

Retest vsimage please

2 similar comments
@jleveque
Copy link
Contributor Author

Retest vsimage please

@jleveque
Copy link
Contributor Author

Retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jul 18, 2020

retest this please

@jleveque
Copy link
Contributor Author

Retest broadcom please

@jleveque
Copy link
Contributor Author

Retest vs please

7 similar comments
@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque
Copy link
Contributor Author

Retest vs please

@jleveque jleveque merged commit 43b5832 into sonic-net:master Jul 20, 2020
@jleveque jleveque deleted the sudoers_sonic_installer branch July 20, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees

@jleveque jleveque

Labels
Enhancement ➕ Request for 202006 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jleveque @lguohan @qiluo-msft