Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-commit PR #432 (SHA 4546372) #474

Merged
merged 2 commits into from
Apr 3, 2017
Merged

Re-commit PR #432 (SHA 4546372) #474

merged 2 commits into from
Apr 3, 2017

Conversation

taoyl-ms
Copy link
Contributor

@taoyl-ms taoyl-ms commented Apr 3, 2017 •
edited
Loading

We reverted #432 in #457 as we observed in Microsoft testbed that sonic switches were unable to get correct DHCP response after that commit.

However, by investigation it turns out that this is an environment issue rather than SONiC code issue. (Certain brand of switches that are used as mgmt switch in Microsoft testbed failed to forward the DHCP ACK packet). Therefore we are re-committing this change back. Though, we'll disable the feature temporarily by not requesting that DHCP option until we find a final solution to the testbed issue.

@taoyl-ms taoyl-ms requested a review from lguohan April 3, 2017 23:07
@taoyl-ms taoyl-ms merged commit 8c76556 into sonic-net:master Apr 3, 2017
lguohan added a commit that referenced this pull request May 19, 2018
@lguohan
[swss]: update swss submodule
bf2be4a 
* a1b6fa3 2018-04-16 | [vlanmgr]: Fix the incorrect ip link del command for vlan remove (#474) (HEAD, origin/201803) [Jipan Yang]
* 66287cf 2018-05-18 | fix SAI_BUFFER_PROFILE_ATTR_SHARED_DYNAMIC_TH value type mismatch bug (#502) [yangbashuang]
* 43365f3 2018-05-14 | [crmorch]: neighbor used counter increased twice (#472) (#501) [MaxPolovyi]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
yxieca added a commit to yxieca/sonic-buildimage that referenced this pull request Mar 30, 2019
@yxieca
[utilities] advance utilities sub-module head
4a6dc09 
Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (sonic-net#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (sonic-net#474)
@yxieca yxieca mentioned this pull request Mar 30, 2019
Merged
yxieca added a commit that referenced this pull request Mar 31, 2019
@yxieca
[201811][snmpagent][swss-common] advance sub module head to include o…
1b07437 
…verlay SNMP (#2721)

* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (#102)
  > Enable overriding interface counters OIDs (#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (#474)
@wendani wendani mentioned this pull request Apr 9, 2019
Merged
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][snmpagent][swss-common] advance sub module head to include o…
6930af3 
…verlay SNMP (sonic-net#2721)

* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (#102)
  > Enable overriding interface counters OIDs (#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (sonic-net#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (sonic-net#474)
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][snmpagent][swss-common] advance sub module head to include o…
a669b30 
…verlay SNMP (sonic-net#2721)

* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (#102)
  > Enable overriding interface counters OIDs (#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (sonic-net#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (sonic-net#474)
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 10, 2019
@yxieca @tiantianlv
[201811][snmpagent][swss-common] advance sub module head to include o…
6182dbe 
…verlay SNMP (sonic-net#2721)

* [snmpagent][swss-common] advance sub module head to include overlay SNMP

Submodule src/sonic-snmpagent 0f2bbd7..26f0495:
  > Remove verbose feature missing logs (#102)
  > Enable overriding interface counters OIDs (#98)

Submodule src/sonic-swss-common 5f4abd9..36fd5e9:
  > Add new DB index for SNMP_OVERLAY_DB (#262)

Note: overlay DB also requires change in swss-common, which has been
      moved ahead.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* [utilities] advance utilities sub-module head

Submodule src/sonic-utilities 9d9aaa0..d1070b2:
  > [warm-reboot] initialize warm reboot state table before warm rebooting (sonic-net#492)
  > Allow config shutdown and startup operations on valid PortChannel interface names (sonic-net#474)
lguohan pushed a commit that referenced this pull request Apr 12, 2019
@wendani @lguohan
[submodule]: submodule update for PFC watchdog warm reboot commits (#…
9b6a2fb 
…2755)

sonic-sairedis:
e8cb879 Make object list deterministic when iterating (#438)
5486f97 Ignore ACL_COUNTER bytes and packets during comparison logic (#443)
b138ff9 Notify OA about exception and process only restart query events (#437)
0974a43 Set MTU value on created tap device for virtual switch (#436)
e2f50e8 Increase eth buffer size to 16k for virtual switch (#435)
79fb388 [bfn] Ged rid of ld_preload. Link against libsai only (#429)
2e47b78 Remove MAC alignment WA for Mellanox platforms. (#430)
e1354fe Add pre match to comparison logic and unittests (#423)
18a5ebb Drop FDB notifications if they contain invalid OIDs (#428)

sonic-swss-common:
8af58ad sonic-swss-common: Add vxlan macros to schema (#269)
76837bf Make class Select support batch read from selectables (#270)
4cf643e Add multiple fields hdel support (#267)
a710529 Update PFC_WD table name in CONFIG_DB (#266)
3c452c1 Update README.md (#268)

sonic-swss:
e329dbd Survive pfc watchdog storm action across warm-reboot (#794)

sonic-utilities:
6ee0aea (HEAD, origin/master, origin/HEAD) [config]: Change the order of interface commands (#504)
5ae30d2 [show vlan brief] Support 'alias' interface naming mode (#497)
bafebf9 Update neighbor advertiser (#498)
fa90083 [clear/main.py]: clear ndp command. (#450)
65f69e4 [show interface neighbor expected] Support 'alias' interface naming mode (#495)
aae39e7 updated show ipv6 interface for alias mode (#493)
170fed9 [warm-reboot] initialize warm reboot state table before warm rebooting (#492)
06cd99f Allow config shutdown and startup operations on valid PortChannel interface names (#474)
98cdebb [show ip interface] Add support for 'alias' interface naming mode (#486)
5f1de81 [show] Add serial numbers/uptime/hwinfo to 'show version' output (#488)
e78a866 [route_check] Move scripts under scripts/ directory, add to setup.py (#489)
d347527 Change PFC watchdog CONFIG_DB table name from PFC_WD_TABLE to PFC_WD (#475)

Signed-off-by: Wenda Ni <wenni@microsoft.com>
stcheng pushed a commit to stcheng/sonic-buildimage that referenced this pull request Jul 19, 2019
[submodule]: Update swss related submodules
6b378b1 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (sonic-net#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (sonic-net#915)
Fix typo in orchagent_restart_check from fasle to false. (sonic-net#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (sonic-net#925)
Add retryCount option for orchagent_restart_check program. (sonic-net#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (sonic-net#874)
[intfsorch] Wait for interface prior to prefix (sonic-net#796)
Set timer only when interval changes. Not in each firing of the timer. (sonic-net#945)
[test]: Fix set interface in configuration database (sonic-net#956)
[copporch]: Fix polymorphic type error (sonic-net#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (sonic-net#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (sonic-net#953)
[portsorch]: Add reference count of port (sonic-net#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (sonic-net#950)
remove crm acl_counters when acl_table removed (sonic-net#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (sonic-net#966)
[policerorch]: Fix return code comparison error (sonic-net#968)
[gitignore]: Add swss-dbg related files (sonic-net#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (sonic-net#934)
[vxlanorch]: Add extra info into NOTICE logs (sonic-net#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (sonic-net#955)
[copporch]: Fix copporch in DEL command (sonic-net#972)
[orchagent]: Fix crash during orchagent process exit (sonic-net#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (sonic-net#958)
[test]: Skip unstable test test_vnet_orch_1 (sonic-net#976)
[intfsorch]: Fix rif flex counter removal error (sonic-net#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (sonic-net#981)
[teamsyncd]: Add information for LAG membership changes (sonic-net#982)

common:
Add an assert to logger, which will log a message and abort. (sonic-net#286)
[test]: Add IpAddress::isZero() unit test (sonic-net#289)
do not abort when read timerfd return 0 and errno = 0 (sonic-net#291)
Add BGP_STATE_TABLE in stateDB (sonic-net#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (sonic-net#285)
Add ignore Wshadow pragma to json.hpp (sonic-net#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (sonic-net#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (sonic-net#294)
timerfd:read failure - Record in logs as error. (sonic-net#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (sonic-net#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (sonic-net#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (sonic-net#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (sonic-net#472)
Fixed config_syncd_barefoot function (sonic-net#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (sonic-net#480)
Add default bridge id for bridge port id of type PORT in virtual switch (sonic-net#473)
Fix a bug in parsing kernel argument of fast-reboot (sonic-net#482)
Add TimerWatchdog for monitoring long execution apis (sonic-net#469)
Add specific comparison logic for tunnel map (sonic-net#475)
[vslib] add ACL action capabilities support (sonic-net#481)
Per buffer pool watermark polling mode (sonic-net#485)
Add specific comparison logic for ACL counter (sonic-net#484)
Process flex counters requests in separate thread (sonic-net#483)
Make sairedis/syncd synchronous (sonic-net#476)
Fixed conditional operator. (sonic-net#487)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@stcheng stcheng mentioned this pull request Jul 19, 2019
Merged
lguohan pushed a commit that referenced this pull request Jul 20, 2019
@stcheng @lguohan
[submodule]: Update swss related submodules (#3190)
01a5bea 
swss:
[vxlanorch]: Allow ipv6 src ip for Vxlan tunnel creation (#896)
[aclorch]: Allow DTEL drop actions in DTEL flow watchlist (#915)
Fix typo in orchagent_restart_check from fasle to false. (#923)
[sonic-swss]: Fix for FPM accept call failure in ARM arch (#925)
Add retryCount option for orchagent_restart_check program. (#833)
[vlan] Add pytest cases to validate nonexistent vlan behavior. (#874)
[intfsorch] Wait for interface prior to prefix (#796)
Set timer only when interval changes. Not in each firing of the timer. (#945)
[test]: Fix set interface in configuration database (#956)
[copporch]: Fix polymorphic type error (#946)
[AclOrch]: Fix the acl mirror counter doubled by inactive mirror and active again (#952)
[MirrorOrch]: Init the next hop ip with 0 instead of default constructor (#953)
[portsorch]: Add reference count of port (#962)
[mock_test]: Move mock tests into a separate folder to separate them from vs tests (#950)
remove crm acl_counters when acl_table removed (#918)
[aclorch]: Fix matching MIRROR_DSCP throws unnecessary errors (#966)
[policerorch]: Fix return code comparison error (#968)
[gitignore]: Add swss-dbg related files (#967)
[vxlanmgrd]: Fix for vxlanmgrd cannot correctly work after config reload (#934)
[vxlanorch]: Add extra info into NOTICE logs (#891)
[test]: Add a neighbor entry with BCAST MAC and verify its ignored (#955)
[copporch]: Fix copporch in DEL command (#972)
[orchagent]: Fix crash during orchagent process exit (#974)
[vnetorch]: Fix VNET orchagents order for warm-reboot flow (#958)
[test]: Skip unstable test test_vnet_orch_1 (#976)
[intfsorch]: Fix rif flex counter removal error (#975)
Update tests README.md file
[aclorch]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#978)
[test]: Skip test_watermark.py::TestWatermark::test_lua_plugins (#981)
[teamsyncd]: Add information for LAG membership changes (#982)

common:
Add an assert to logger, which will log a message and abort. (#286)
[test]: Add IpAddress::isZero() unit test (#289)
do not abort when read timerfd return 0 and errno = 0 (#291)
Add BGP_STATE_TABLE in stateDB (#273)
[IpAddress]: add mcast scope on address and isFullMask method on prefix (#285)
Add ignore Wshadow pragma to json.hpp (#292)
[executor]: Fix Executor does not get correct priority saved in m_selectable (#290)
[schema]: Remove duplicate STATE_MIRROR_SESSION_TABLE_NAME (#294)
timerfd:read failure - Record in logs as error. (#295)
[schema]: Change CFG_ACL_TABLE_NAME to CFG_ACL_TABLE_TABLE_NAME (#296)
[schema]: Add PASS_THROUGH_ROUTE_TABLE to config and application db (#297)

sairedis:
ARM32 bit fixes, for 64bit printf format specifier (#468)
Reduce the timeout (GET_RESPONSE_TIMEOUT) from 6 minutes to 1 minute. (#472)
Fixed config_syncd_barefoot function (#474)
[syncd_init_common.sh] fix fast reboot backwards compatibility (#480)
Add default bridge id for bridge port id of type PORT in virtual switch (#473)
Fix a bug in parsing kernel argument of fast-reboot (#482)
Add TimerWatchdog for monitoring long execution apis (#469)
Add specific comparison logic for tunnel map (#475)
[vslib] add ACL action capabilities support (#481)
Per buffer pool watermark polling mode (#485)
Add specific comparison logic for ACL counter (#484)
Process flex counters requests in separate thread (#483)
Make sairedis/syncd synchronous (#476)
Fixed conditional operator. (#487)

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@kirankella @qiluo-msft
Allow config shutdown and startup operations on valid PortChannel int…
06cd99f 
…erface names (sonic-net#474)

* Avoid shutdown/startup commands on invalid interface names
* sonic-utilities: Fix bug in the show command to display a specific interface status
* sonic-utilities: Check for the presence of interface in port table instead of the optional alias attribute
* Addressed review comment for sonic-net#424
* Undone the change in intfutil file to push that fix in a seperate PR.
* Corrected the error message string for 'config interface <invalid-interface-name> tartup/shutdown'.
* [sonic-utilities] Fix to shutdown and startup on valid PortChannel interface names
* [sonic-utilities] Allow shutdown/startup commands to be done using the alias names of PORTs.
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@jipanyang @lguohan
[vlanmgr]: Fix the incorrect ip link del command for vlan remove (son…
880c1e9 
…ic-net#474)

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
@jipanyang @lguohan
[vlanmgr]: Fix the incorrect ip link del command for vlan remove (son…
a1b6fa3 
…ic-net#474)

Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
dmytroxshevchuk pushed a commit to dmytroxshevchuk/sonic-buildimage that referenced this pull request Aug 31, 2020
@msosyak @prsunny
Fixed config_syncd_barefoot function (sonic-net#474)
82e908e 
Signed-off-by: Myron Sosyak <msosyak@barefootnetworks.com>
yxieca pushed a commit that referenced this pull request Jul 13, 2024
@mssonicbld
[submodule] Update submodule sonic-platform-daemons to the latest HEA…
2ceacd4 
…D automatically (#18744)

src/sonic-platform-daemons

* dee5310 - (HEAD -> 202205, origin/202205) [ci] Fix 202205 pipeline issue. (#474) (3 months ago) [Liu Shilong]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taoyl-ms @lguohan