Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] update eeprom.py plugin #4364

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Conversation

mykolaf
Copy link
Collaborator

@mykolaf mykolaf commented Apr 3, 2020

Signed-off-by: Mykola Faryma mykolaf@mellanox.com

- What I did

Add logic which makes plugin read eeprom from hexdump on Mellanox SimX.
This will eliminate the need to patch the hardware managment package, adding a mock of the eeprom.
For real switch there is no change.
- How I did it

- How to verify it

decode-syseeprom

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2020

This pull request fixes 1 alert when merging ed871bdb8a601bbd5939c09c63765db143272777 into ea38d06 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
@lgtm-com
Copy link

lgtm-com bot commented Apr 3, 2020

This pull request fixes 1 alert when merging 3983d08 into ea38d06 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@jleveque jleveque merged commit c5c1ae2 into sonic-net:master Apr 3, 2020
abdosi pushed a commit that referenced this pull request Apr 7, 2020
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
tiantianlv pushed a commit to SONIC-DEV/sonic-buildimage that referenced this pull request Apr 24, 2020
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants