Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DellEMC] Platform2.0 API Implementation for Watchdog [Z9264F] #4192

Merged
merged 4 commits into from
Apr 6, 2020

Conversation

santhosh-kt
Copy link
Contributor

- What I did

  • [DellEMC] Platform2.0 API Implementation for Watchdog [Z9264F]

- How I did it

  • Added new file watchdog.py in sonic_platform directory.
  • Enabled API support to Enable/disable watchdog.

- How to verify it

- Description for the changelog

On branch z9264f-watchdog
Changes to be committed:
(use "git reset HEAD ..." to unstage)

    modified:   platform/broadcom/sonic-platform-modules-dell/z9264f/sonic_platform/chassis.py
    new file:   platform/broadcom/sonic-platform-modules-dell/z9264f/sonic_platform/watchdog.py

- A picture of a cute animal (not mandatory but encouraged)

@sujinmkang
Copy link
Collaborator

retest vsimage please

sujinmkang
sujinmkang previously approved these changes Feb 26, 2020
Copy link
Collaborator

@sujinmkang sujinmkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me.

@santhosh-kt
Copy link
Contributor Author

retest vsimage please

@jleveque
Copy link
Contributor

jleveque commented Mar 5, 2020

@santhosh-kt: Please fix conflicts.

@jleveque
Copy link
Contributor

@santhosh-kt: Please fix recent conflicts.

@santhosh-kt
Copy link
Contributor Author

2.0 Fan.py PR #4191 also keeps on getting merge conflict on chassis.py. After the PR merged, I will resolve these conflicts to avoid reviews getting dismissed multiple times.

@santhosh-kt
Copy link
Contributor Author

retest default please

@santhosh-kt
Copy link
Contributor Author

retest this please

@sujinmkang sujinmkang merged commit 7bc8f12 into sonic-net:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants