[teamd] fix lacp fallback mode breakage in teamd v1.28 #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In teamd v1.28, the port can only be enabled if sync bit is set in recveived LACPDU from partner by the following commit "teamd: lacp: update port state according to partner's sync bit" (jpirko/libteam@54f137c) However, lacp fallback feature needs to enable port even if partner LACPDU is not received within a given period and fallback cfg is enabled. To fix the lacp fallback breakage, we have to bypass the sync bit check in lacp fallback mode. Signed-off-by: Haiyang Zheng <haiyang.z@alibaba-inc.com>
hzheng5
force-pushed
the
teamd_1.28_fallback
branch
from
cb9c45a
to
96260f7
Compare
|
retest vsimage please |
pavel-shirshov
approved these changes
Oct 11, 2019
| 2017 21:07:53 -0800 | ||
| commit f475746f56602a40861b8d94eac5f0979c4703f3 | ||
| Author: yorke <yorke.yuan@asterfusion.com> | ||
| Date: Mon Jun 3 12:02:36 2019 +0800 |
There was a problem hiding this comment.
Thanks for the review. Looks like it's already merged.
|
@pavel-shirshov , can you also check the test mention in the pr and approve or not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #951
In teamd v1.28, the port can only be enabled if sync bit is set
in recveived LACPDU from partner by the following commit
"teamd: lacp: update port state according to partner's sync bit"
(jpirko/libteam@54f137c)
However, lacp fallback feature needs to enable port even if partner
LACPDU is not received within a given period and fallback cfg is enabled.
To fix the lacp fallback breakage, we have to bypass the sync bit
check in lacp fallback mode.
Signed-off-by: Haiyang Zheng haiyang.z@alibaba-inc.com
- What I did
Fix lacp fallback mode breakage in teamd v 1.28
- How I did it
bypass the sync bit check in lacp fallback mode, which is introduced in teamd v1.28 and later
- How to verify it
verify that the port can enter and exit lacp fallback mode with the change as expected.
And the change passed the following test case
https://github.com/Azure/sonic-mgmt/pull/379/files
- Description for the changelog
[teamd] fix lacp fallback mode breakage in teamd v1.28
- A picture of a cute animal (not mandatory but encouraged)