[build]: allow single src file to build multiple independent debian p… #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ackages add_derived_package setup dependency between the main deb and derived deb. The dervied deb depends on the main deb and need to install the main deb. add_peer_package does not setup dependency between the main deb and peer deb, does not require to install the main deb.
|
@marian-pritsak , add_derived_package does not work this case as it will try to install the base deb pacakge. However, I am not sure add_peer_pacakge is the best way to address problem. |
|
@lguohan, can you please describe the problem that you have and give me a usage example, because it is not so clear from PR |
marian-pritsak
suggested changes
Mar 1, 2017
slave.mk
Outdated
| $(SONIC_CLEAN_DEBS) : $(DEBS_PATH)/%-clean : .platform $$(addsuffix -clean,$$(addprefix $(DEBS_PATH)/,$$($$*_DERIVED_FROM))) | ||
| @# remove derived targets if main one is removed, because we treat them | ||
| @# as part of one package | ||
| @rm -f $(addprefix $(DEBS_PATH)/, $* $($*_DERIVED_DEBS)) | ||
|
|
||
| $(SONIC_CLEAN_DEBS) : $(DEBS_PATH)/%-clean : .platform $$(addsuffix -clean,$$(addprefix $(DEBS_PATH)/,$$($$*_MAIN_DEB))) |
There was a problem hiding this comment.
No need for separate pattern rule
Just extend rule above
|
So basically extra_debs are same as derived debs except they are devoid of dependency. |
marian-pritsak
approved these changes
Mar 1, 2017
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Jun 22, 2020
* 77d3417 2020-06-22 | [sonic-swss-common] ARMHF warning fixes (sonic-net#352) (HEAD -> master, origin/master, origin/HEAD) [arheneus@marvell.com] * da8e264 2020-06-21 | [python3]: build python3-swsscommon for python3 support (sonic-net#355) [lguohan] * 292b08a 2020-06-16 | Changes to support SONiC Gearbox Manager (sonic-net#347) [Syd Logan] * 58ca4d9 2020-06-10 | Add missed BGP tables into the schema (sonic-net#351) [pavel-shirshov] * cddfc4e 2020-06-09 | [loglevel] Avoid accessing null ptr in swssloglevel (sonic-net#349) [Stephen Sun] * 8fce898 2020-06-08 | [schema] update schema with rates and utilization table names (sonic-net#330) [Mykola F] Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
added a commit
that referenced
this pull request
Jun 23, 2020
* 77d3417 2020-06-22 | [sonic-swss-common] ARMHF warning fixes (#352) (HEAD -> master, origin/master, origin/HEAD) [arheneus@marvell.com] * da8e264 2020-06-21 | [python3]: build python3-swsscommon for python3 support (#355) [lguohan] * 292b08a 2020-06-16 | Changes to support SONiC Gearbox Manager (#347) [Syd Logan] * 58ca4d9 2020-06-10 | Add missed BGP tables into the schema (#351) [pavel-shirshov] * cddfc4e 2020-06-09 | [loglevel] Avoid accessing null ptr in swssloglevel (#349) [Stephen Sun] * 8fce898 2020-06-08 | [schema] update schema with rates and utilization table names (#330) [Mykola F] Signed-off-by: Guohan Lu <lguohan@gmail.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
AntonHryshchuk
added a commit
to AntonHryshchuk/sonic-buildimage
that referenced
this pull request
Mar 8, 2023
Update sonic-platform-common submodule pointer to include the following: * c551a81 [sonic_ssd] Nokia-7215: Fix show platform ssdhealth ([sonic-net#337](sonic-net/sonic-platform-common#337)) * 1929332 Fix pipeline apt-get purge error. ([sonic-net#349](sonic-net/sonic-platform-common#349)) * 3d57e0e [ssd_generic] Get health status from Remaining_Life_Left field for virtium SSD ([sonic-net#344](sonic-net/sonic-platform-common#344)) Signed-off-by: AntonHryshchuk <antonh@nvidia.com>
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
* Fix pipeline apt-get purge error.
yxieca
pushed a commit
that referenced
this pull request
Apr 18, 2023
Why I did it src/sonic-platform-common * 41e2a6e - (HEAD -> 202205, origin/202205) Fix pipeline apt-get purge error. (#349) (#358) (6 days ago) [Liu Shilong] src/sonic-swss * 804e5ac - (HEAD -> 202205, origin/202205) [FDB]Fixing FDB consolidated flush for Remote MACs (#2673) (#2725) (4 hours ago) [Sudharsan Dhamal Gopalarathnam] src/sonic-utilities * ea1d849a - (HEAD -> 202205, origin/202205) Use sonic-swss-common artifacts from the matching source branch (#2783) (5 days ago) [Saikrishna Arcot]
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…ic-utilities [submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ackages
add_derived_package setup dependency between the main deb and derived deb.
The dervied deb depends on the main deb and need to install the main deb.
add_peer_package does not setup dependency between the main deb and peer deb,
does not require to install the main deb.