-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two parameters into non-blocking T0 PR checker. #19346
Merged
wangxin
merged 1 commit into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/add_two_parameters
Jun 25, 2024
Merged
Add two parameters into non-blocking T0 PR checker. #19346
wangxin
merged 1 commit into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/add_two_parameters
Jun 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaqiangz
approved these changes
Jun 19, 2024
/azpw ms_conflict |
3 similar comments
/azpw ms_conflict |
/azpw ms_conflict |
/azpw ms_conflict |
Commenter does not have sufficient privileges for PR 19346 in repo sonic-net/sonic-buildimage |
/azpw ms_conflict |
4 similar comments
/azpw ms_conflict |
/azpw ms_conflict |
/azpw ms_conflict |
/azpw ms_conflict |
r12f
approved these changes
Jun 25, 2024
wangxin
approved these changes
Jun 25, 2024
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
In this PR, we add two parameters STOP_ON_FAILURE: "False" and RETRY_TIMES: 0 into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
In this PR, we add two parameters STOP_ON_FAILURE: "False" and RETRY_TIMES: 0 into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
In this PR, we add two parameters
STOP_ON_FAILURE: "False"
andRETRY_TIMES: 0
into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)