Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two parameters into non-blocking T0 PR checker. #19346

Merged

Conversation

yutongzhang-microsoft
Copy link
Contributor

Why I did it

In this PR, we add two parameters STOP_ON_FAILURE: "False" and RETRY_TIMES: 0 into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

3 similar comments
@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

Copy link

Commenter does not have sufficient privileges for PR 19346 in repo sonic-net/sonic-buildimage

@wangxin
Copy link
Contributor

wangxin commented Jun 20, 2024

/azpw ms_conflict

4 similar comments
@Pterosaur
Copy link
Contributor

/azpw ms_conflict

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

@yutongzhang-microsoft
Copy link
Contributor Author

/azpw ms_conflict

@wangxin wangxin merged commit d913b1b into sonic-net:master Jun 25, 2024
20 checks passed
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/add_two_parameters branch June 25, 2024 01:19
arun1355492 pushed a commit to arun1355492/sonic-buildimage that referenced this pull request Jul 26, 2024
In this PR, we add two parameters STOP_ON_FAILURE: "False" and RETRY_TIMES: 0 into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.
liushilongbuaa pushed a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Aug 1, 2024
In this PR, we add two parameters STOP_ON_FAILURE: "False" and RETRY_TIMES: 0 into non-blocking T0 PR checker. Which means, one script will only execute once in a testplan, no matter if it fails. And one failed script will not block other remaining test scripts. Test plan will finish executing all test scripts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants