Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chassis][voq] Remove the leaf ref for the ifname in sonic-system-port.yang #18855

Merged
merged 1 commit into from
May 17, 2024

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented May 2, 2024

Why I did it

Work item tracking
  • Microsoft ADO 27934751:

How I did it

Fixes #18854
Update the sonic-system-port.yang to remove the check to have ifname as leafref in the port table
The system-port config table will have all the ports in the chassis not only to one linecard, so in case of the chassis with different linecards sku with different number of ports this leafref will not work.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@arlakshm arlakshm added the chassis-voq Voq chassis changes label May 2, 2024
@arlakshm arlakshm requested a review from qiluo-msft as a code owner May 2, 2024 21:33
@arlakshm arlakshm requested review from kenneth-arista, xincunli-sonic and qiluo-msft and removed request for qiluo-msft May 2, 2024 21:33
@arlakshm arlakshm added the YANG YANG model related changes label May 3, 2024
@arlakshm
Copy link
Contributor Author

arlakshm commented May 6, 2024

/Azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm
Copy link
Contributor Author

arlakshm commented May 7, 2024

test (Test kvmtest-t0 by Elastictest) failures are not related to this change

@arlakshm
Copy link
Contributor Author

arlakshm commented May 7, 2024

/Azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm arlakshm added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label May 8, 2024
@arlakshm
Copy link
Contributor Author

/Azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui added the P0 Priority of the issue label May 15, 2024
@lguohan lguohan merged commit c2406e6 into sonic-net:master May 17, 2024
19 checks passed
@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jun 5, 2024
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
…t.yang (sonic-net#18855)

Microsoft ADO 27934751:

Fixes sonic-net#18854

Update the sonic-system-port.yang to remove the check to have ifname as leafref in the port table
The system-port config table will have all the ports in the chassis not only to one linecard, so in case of the chassis with different linecards sku with different number of ports this leafref will not work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chassis for 202205 branch PRs needed for 202205 branch in msft repo chassis-voq Voq chassis changes Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch P0 Priority of the issue YANG YANG model related changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[chassis] Yang validation fails for the system port yang
8 participants