Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on tsa_enabled flag for BGP peer config during reload #18556

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

tjchadaga
Copy link
Contributor

@tjchadaga tjchadaga commented Apr 3, 2024

Why I did it

Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
  • Microsoft ADO (number only): 27171112

How I did it

Add dependency on tsa_enabled flag before peer configuration

How to verify it

  • Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
  • Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

  • 202205

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

@tjchadaga PR: #18556 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18556 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9831823
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

@tjchadaga tjchadaga marked this pull request as ready for review April 11, 2024 18:35
@tjchadaga
Copy link
Contributor Author

/azpw ms_conflict

@tjchadaga
Copy link
Contributor Author

"/azpw ms_conflict"

@mssonicbld
Copy link
Collaborator

@tjchadaga PR: #18556 is conflict with MS internal repo
Please push fix commit to sonicbld/precheck/head/18556 and approve
https://msazure.visualstudio.com/One/_git/Networking-acs-buildimage/pullrequest/9887874
After ms PR is merged, comment "/azpw ms_conflict" to rerun PR checker.

@tjchadaga
Copy link
Contributor Author

/azpw ms_conflict

@tjchadaga tjchadaga added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Apr 16, 2024
@gechiang
Copy link
Collaborator

@StormLiangMS , @yxieca , can you help review this change?
Thanks!

@StormLiangMS
Copy link
Contributor

Hi @tjchadaga is there a known issue for this one? like routes are advertised out with TSA enabled on a reload? I'm asking this because 202305 piloting is almost done, should I hold the pilot for this one?

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 38502a8 into sonic-net:master Apr 17, 2024
19 checks passed
@tjchadaga
Copy link
Contributor Author

Hi @tjchadaga is there a known issue for this one? like routes are advertised out with TSA enabled on a reload? I'm asking this because 202305 piloting is almost done, should I hold the pilot for this one?

This was identified as a gap. No known issues due to this gap as of now.

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 18, 2024
… bringing up BGP (sonic-net#18556)

Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration

How to verify it
Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202311: #18721

@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Apr 19, 2024
mssonicbld pushed a commit that referenced this pull request Apr 19, 2024
… bringing up BGP (#18556)

Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration

How to verify it
Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Apr 23, 2024
… bringing up BGP (sonic-net#18556)

Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration

How to verify it
Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202305: #18749

mssonicbld pushed a commit that referenced this pull request Apr 24, 2024
… bringing up BGP (#18556)

Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration

How to verify it
Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024
… bringing up BGP (sonic-net#18556)

Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload

Work item tracking
Microsoft ADO (number only): 27171112
How I did it
Add dependency on tsa_enabled flag before peer configuration

How to verify it
Validate that the BGP session bring up is not complete until tsa_enabled flag is populated.
Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants