-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency on tsa_enabled flag for BGP peer config during reload #18556
Conversation
@tjchadaga PR: #18556 is conflict with MS internal repo |
/azpw ms_conflict |
"/azpw ms_conflict" |
@tjchadaga PR: #18556 is conflict with MS internal repo |
/azpw ms_conflict |
@StormLiangMS , @yxieca , can you help review this change? |
Hi @tjchadaga is there a known issue for this one? like routes are advertised out with TSA enabled on a reload? I'm asking this because 202305 piloting is almost done, should I hold the pilot for this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was identified as a gap. No known issues due to this gap as of now. |
… bringing up BGP (sonic-net#18556) Why I did it Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload Work item tracking Microsoft ADO (number only): 27171112 How I did it Add dependency on tsa_enabled flag before peer configuration How to verify it Validate that the BGP session bring up is not complete until tsa_enabled flag is populated. Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
Cherry-pick PR to 202311: #18721 |
… bringing up BGP (#18556) Why I did it Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload Work item tracking Microsoft ADO (number only): 27171112 How I did it Add dependency on tsa_enabled flag before peer configuration How to verify it Validate that the BGP session bring up is not complete until tsa_enabled flag is populated. Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
… bringing up BGP (sonic-net#18556) Why I did it Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload Work item tracking Microsoft ADO (number only): 27171112 How I did it Add dependency on tsa_enabled flag before peer configuration How to verify it Validate that the BGP session bring up is not complete until tsa_enabled flag is populated. Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
Cherry-pick PR to 202305: #18749 |
… bringing up BGP (#18556) Why I did it Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload Work item tracking Microsoft ADO (number only): 27171112 How I did it Add dependency on tsa_enabled flag before peer configuration How to verify it Validate that the BGP session bring up is not complete until tsa_enabled flag is populated. Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
… bringing up BGP (sonic-net#18556) Why I did it Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload Work item tracking Microsoft ADO (number only): 27171112 How I did it Add dependency on tsa_enabled flag before peer configuration How to verify it Validate that the BGP session bring up is not complete until tsa_enabled flag is populated. Ensure no traffic is drawn to the device when in TSA and reboot with BGP unshut.
Why I did it
Ensure BGP peer bring-up and route advertisements are done only after checking TSA status during reload
Work item tracking
How I did it
Add dependency on tsa_enabled flag before peer configuration
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)