[Mellanox] Revert LPM implementation to the old way #17096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onic-net#16545)" This reverts commit 456a90e.
)" This reverts commit 18cf719.
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
/azpw run ms_conflict |
|
/AzurePipelines run ms_conflict |
|
No pipelines are associated with this pull request. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Kebo Liu <kebol@nvidia.com>
keboliu
changed the title
Junchao-Mellanox
approved these changes
Nov 16, 2023
|
@keboliu can you please elaborate more on the backward compatibility? |
…he dependency on sx_api importing Signed-off-by: Kebo Liu <kebol@nvidia.com>
Hi @prgeor if you remember our current LPM implementation will require the user to explicitly shut down (admin down) the port first, this is not consistence with our original implementation - the user can toggle the LPM regardless of the port admin status. now in this PR we change it back, allowing the user to toggle the LPM w/o shutting down the ports beforehand. |
dgsudharsan
approved these changes
Nov 18, 2023
11 tasks
Signed-off-by: Kebo Liu <kebol@nvidia.com>
Signed-off-by: Kebo Liu <kebol@nvidia.com>
updated. |
liat-grozovik
approved these changes
Nov 27, 2023
|
verified on top of 202305 commit 733a902 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 30, 2023
- Why I did it The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status. - How I did it Revert the recent changes related to LPM in PR sonic-net#14130 and sonic-net#16545 - How to verify it Run all sfputil and SFP platform API related tests on all the Mellanox platforms. Signed-off-by: Kebo Liu <kebol@nvidia.com>
|
Cherry-pick PR to 202305: #17366 |
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Nov 30, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
yxieca
pushed a commit
that referenced
this pull request
Dec 4, 2023
- Why I did it The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status. - How I did it Revert the recent changes related to LPM in PR #14130 and #16545 - How to verify it Run all sfputil and SFP platform API related tests on all the Mellanox platforms. Signed-off-by: Kebo Liu <kebol@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The current low power mode setting implementation requests the user to set the port to admin down first before toggling LP mode, this is not backward compatible, now revert it to the old way so that the user can toggle the LP mode regardless of the port admin status.
Work item tracking
How I did it
Revert the recent changes related to LPM in PR #14130 and #16545
How to verify it
run all sfputil and SFP platform API related tests on all the Mellanox platforms.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)