[gbsyncd] Graceful shutdown of syncd process in container gbsyncd #16812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
previously approved these changes
Oct 27, 2023
|
/azpw ms_conflict |
1 similar comment
|
/azpw ms_conflict |
11 tasks
lguohan
pushed a commit
that referenced
this pull request
Dec 14, 2023
…7486) The issue is related to #16812. Process syncd does not run in the container gbsyncd on kvm sonic with default hwsku. Microsoft ADO : 26151608 How I did it If syncd has not run in container gbsyncd, it is not needed to trigger graceful shudown of syncd. How to verify it None of syncd_request_shutdown coredump in config reload on KVM sonic
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 15, 2023
…nic-net#16812) Fix sonic-net#16608. Need to gracefully shutdown syncd/gbsyncd individually.
|
Cherry-pick PR to 202305: #17523 |
11 tasks
|
Cherry-pick PR to 202311: #17531 |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 16, 2023
…nic-net#16812) Fix sonic-net#16608. Need to gracefully shutdown syncd/gbsyncd individually.
11 tasks
mssonicbld
added a commit
that referenced
this pull request
Dec 17, 2023
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
|
@jimmyzhai , is this fix not needed by 202205? should we backport this for 202205? |
jimmyzhai
added a commit
to jimmyzhai/sonic-buildimage
that referenced
this pull request
Dec 19, 2023
…nic-net#16812) Fix sonic-net#16608. Need to gracefully shutdown syncd/gbsyncd individually.
11 tasks
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Dec 19, 2023
…nic-net#17486) The issue is related to sonic-net#16812. Process syncd does not run in the container gbsyncd on kvm sonic with default hwsku. Microsoft ADO : 26151608 How I did it If syncd has not run in container gbsyncd, it is not needed to trigger graceful shudown of syncd. How to verify it None of syncd_request_shutdown coredump in config reload on KVM sonic
11 tasks
Looks 202205 is old and gearbox is not used in production on that. |
yxieca
pushed a commit
that referenced
this pull request
Dec 20, 2023
|
@jimmyzhai do we still need this change in 202311 or have it been included with your manual cherry-picking PR? |
Included in 202311 with manual cherry-picking #17563 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #16608. Need to gracefully shutdown syncd/gbsyncd individually.
Work item tracking
How I did it
Update hook stopplatform1 in gbsyncd.sh.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)