[Telemetry] enable default service config if no configs from DB #16683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue 16533, telemetry service exit in master and 202305 branches. Enable default config if no TELEMETRY configs from redis DB. After the fix, telemetry service would work with the following two scenarios: 1. With TELEMETRY config in redis DB, load service configs from DB. 2. No TELEMETRY config in redis DB, use default service configs.
qnos
force-pushed
the
telemetry-service-exit-fix
branch
from
fcf6ab4
to
c86af63
Compare
FengPan-Frank
approved these changes
Sep 26, 2023
FengPan-Frank
approved these changes
Sep 27, 2023
zbud-msft
approved these changes
Sep 27, 2023
qiluo-msft
approved these changes
Sep 28, 2023
|
@zbud-msft @qiluo-msft if you support this backport, do we have ADO to track? |
|
@qnos have you tested with 202305? |
The issue only exists in Master and 202305 branch. Yes, verified it in 202305 branch. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Oct 17, 2023
…-net#16683) #### Why I did it Fix issue sonic-net#16533 , telemetry service exit in master and 202305 branches due to no telemetry configs in redis DB. #### How I did it Enable default config if no TELEMETRY configs from redis DB. #### How to verify it After the fix, telemetry service would work with the following two scenarios: 1. With TELEMETRY config in redis DB, load service configs from DB. 2. No TELEMETRY config in redis DB, use default service configs.
|
Cherry-pick PR to 202305: #16913 |
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Oct 21, 2023
#### Why I did it Fix issue #16533 , telemetry service exit in master and 202305 branches due to no telemetry configs in redis DB. #### How I did it Enable default config if no TELEMETRY configs from redis DB. #### How to verify it After the fix, telemetry service would work with the following two scenarios: 1. With TELEMETRY config in redis DB, load service configs from DB. 2. No TELEMETRY config in redis DB, use default service configs.
mssonicbld
added
Included in 202305 Branch
and removed
Created PR to 202305 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix issue #16533 , telemetry service exit in master and 202305 branches due to no telemetry configs in redis DB.
How I did it
Enable default config if no TELEMETRY configs from redis DB.
How to verify it
After the fix, telemetry service would work with the following two scenarios:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)