Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utilities]: Update sonic-utilities submodule #1220

Merged
merged 1 commit into from
Dec 9, 2017

Conversation

stcheng
Copy link
Contributor

@stcheng stcheng commented Dec 8, 2017

Adapt to py-swsssdk refactor of mod_entry and mod_config (#165)
[intfutil]: Fix python indentation (#166)

Signed-off-by: Shu0T1an ChenG shuche@microsoft.com

@lguohan
Copy link
Collaborator

lguohan commented Dec 8, 2017

please update the sonic-py-swsssdk

Copy link
Collaborator

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update sonic-py-swsssdk

@stcheng
Copy link
Contributor Author

stcheng commented Dec 8, 2017

fixed

it seems that we lack some tests so that even the corresponding submodule is not updated the build passes.

@jleveque
Copy link
Contributor

jleveque commented Dec 8, 2017

@stcheng: Currently, the PR build test for sonic-utilities only ensures the Debian package is built successfully. I agree that we could use to add a unit test suite in the future.

[py-swsssdk]: Adapt to py-swsssdk refactor of mod_entry and mod_config (sonic-net#165)
[intfutil]: Fix python indentation (sonic-net#166)

Change set_config to mod_config

Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
@lguohan
Copy link
Collaborator

lguohan commented Dec 8, 2017

@taoyl-ms

@lguohan lguohan requested a review from taoyl-ms December 8, 2017 22:48
@stcheng stcheng merged commit b9a0ef8 into sonic-net:master Dec 9, 2017
@stcheng stcheng deleted the util branch December 9, 2017 01:28
theasianpianist pushed a commit to theasianpianist/sonic-buildimage that referenced this pull request Feb 5, 2022
Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants