Auto-completion, help (?), cmd navigation (up arrow) not working in vtysh on host system. #1124

nikos-github · 2017-11-07T01:56:13Z

Auto-completion, help (?), cmd navigation (up/down arrows) not working in vtysh on host system.
This fix complements sonic-net/sonic-quagga#19

RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=

A=

This reverts commit c9a2c92.

This reverts commit 45ab087.

Sync to master

Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.

…ling to a more relevant place for this cmd. Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.

Sync to master

…tysh on host system. RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=

lguohan · 2017-11-07T03:05:53Z

why are there so many commits in your PR? are you synced with the master to generate the PR?

nikos-github · 2017-11-07T03:34:34Z

This is the commit and sync history of my private branch. I don't think it affect Azure/sonic-buildimage. My private branch is synced to latest master the way github does it. I then generate the PR on the delta.

lguohan · 2017-11-07T03:37:29Z

it causes issue in the merge messages, the commit message will by default includes all previous commit messages, we have to manually edited it.

nikos-github · 2017-11-07T04:14:50Z

I'm just following regular github process. If you have a suggestion that omits that without squashing the history of my private branch or deleting it, let me know.

lguohan · 2017-11-07T06:08:29Z

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

We recommend that you make changes in a topic branch, so that you can push followup commits if you receive feedback on your pull request.

first, you make yout topic branch exactly the same as the master branch, then cherry-pick your commits and finally generate PR.

nikos-github · 2017-11-07T06:12:37Z

My topic branch/fork is long lived. I sync to the latest master each time, commit to it and I generate the PR as the above link suggests. That's how it picks up the delta of the diffs and the comparison is across the fork and the master.

lguohan · 2017-11-07T06:21:17Z

as time goes, you will have more and more commits in your PR. We cannot really know which commits is the one you want to merge.

nikos-github · 2017-11-07T06:33:13Z

Of course you do - you have the diffs of what I want to be merged. The PR generates always the delta. And on my side I want the pull requests directly on my forks not on topic branches. This is a valid way to work on github.

lguohan · 2017-11-07T06:43:31Z

https://gist.github.com/Chaser324/ce0505fbed06b947d962

I think we can discuss the workflow offline.

back to the PR, I tried this, vtysh will give me (END), I need to manually type 'q' to make the (END) go away. Am I missing anything here?

nikos-github · 2017-11-07T06:59:02Z

Cmds work fine for me. What exactly are you trying out?

lguohan · 2017-11-07T07:07:17Z

this problem: http://www.brianlinkletter.com/quagga-vtysh-shell-end-problem/

nikos-github · 2017-11-07T07:12:25Z

In files/image_config/environment/environment the vtysh pager is set to more. Sounds like the quagga docker needs more fixing in addition to this one. On our side with frr, the pager is set properly to more and all commands work fine including the sonic show cli as well as everything inside vtysh.

admin@lnos-x1-a-asw01:~$ set|grep PAGER
VTYSH_PAGER=more

What's the VTYSH_PAGER env variable set to in your case?

lguohan · 2017-11-07T07:18:18Z

I think in this case, the vtysh is looking for the env inside the docker. If frr is working for you, then, can you limit this PR to only FRR? With -t, the vtysh is not working for us.

nikos-github · 2017-11-07T18:57:06Z

Which click cli is it breaking for you?

There is no reason why quagga shouldn't match frr on the environment variables but I will test the setting for quagga and will update the diffs.

rodnymolina · 2017-11-07T19:13:33Z

Any "show" command (e.g. show bgp sum). Btw, i'm referring to my Quagga fix, not FRR one (yours).

nikos-github · 2017-11-07T19:21:22Z

I will test in quagga and see and fix accordingly if possible.

nikos-github · 2017-11-10T03:11:50Z

@lguohan Ok I fixed this in quagga by pointing the docker's pager to cat instead of less. I tested it extensively and it works. Are you ok with that change? Want me to post the diffs?

nikos-github · 2017-11-10T20:32:24Z

The changes below will complete the fix for quagga/vtysh:

diff --git a/debian/quagga.postinst b/debian/quagga.postinst
index bed2fd3..20c6d76 100644
--- a/debian/quagga.postinst
+++ b/debian/quagga.postinst
@@ -1,5 +1,8 @@
#!/bin/bash -e

+rm /etc/alternatives/pager
+ln -s /bin/cat /etc/alternatives/pager
+
if [ -n "$DEBIAN_SCRIPT_DEBUG" ]; then set -v -x; DEBIAN_SCRIPT_TRACE=1; fi
${DEBIAN_SCRIPT_TRACE:+ echo "#42#DEBUG# RUNNING $0 $*"}

Are you ok with those changes?

nikos-github · 2017-11-10T22:06:58Z

I have submitted the PR for quagga as well. Please approve.

lguohan · 2017-11-10T22:19:41Z

can you update the sonic-quagga submodule head in this PR?

…ng in vtysh on host system. (sonic-net#1124)

…ng in vtysh on host system. (#1124) (#1227)

Enable m_isCombinedMirrorV6Table for BFN platform (#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (#1132) Default action for Egress ACL Table not poulated. (#1208) Add/Del lag_name_map item according to lag adding and removing (#1124) Increase ip2me CIR/CBR for faster in-band file transfers (#1000)

Enable m_isCombinedMirrorV6Table for BFN platform (sonic-net#1212) [vnet]: Update VNET route table size to 40K for BITMAP implementation (sonic-net#1132) Default action for Egress ACL Table not poulated. (sonic-net#1208) Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124) Increase ip2me CIR/CBR for faster in-band file transfers (sonic-net#1000)

[aclorch] Use IPv6 Next Header internally for protocol number on MLNX platform (sonic-net#1343) Add/Del lag_name_map item according to lag adding and removing (sonic-net#1124) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

[aclorch] Use IPv6 Next Header internally for protocol number on MLNX platform (#1343) Add/Del lag_name_map item according to lag adding and removing (#1124) Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Fix load minigraph on 201911 branch. (#1124) Fixed config load_minigrpah not working for Multi-asic platfroms. (#1123) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

…-net#1124) The code is to add/del items in LAG_NAME_MAP_TABLE in COUNTERS_DB if a lag is added or removed. The code need the below pull request: sonic-net#51 in Azure/sonic-py-swsssdk read portchannel name from LAG_NAME_MAP_TABLE in COUNTERS_DB sonic-net#51 For use of LAG_NAME_MAP_TABLE in COUNTERS_DB just like fdbshow. I have create another pull request in Azure/sonic-utilities: Show mac learned on lag interface sonic-net#730

Nikos Triantafillis and others added 17 commits August 22, 2017 13:09

IPv4 prefixes shouldn't be sent by default over IPv6 session with FRR.

0766365

RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=

RR client support in minigraph for FRR

45ab087

A=

Sync to master

c9a2c92

Revert "Sync to master"

38a8261

This reverts commit c9a2c92.

Revert "RR client support in minigraph for FRR"

9c69587

This reverts commit 45ab087.

Merge pull request #3 from Azure/master

99300a5

Sync to master

RR client support in minigraph for FRR

8aa3ef5

Correcting j2 file for rrclient support

6e2ef2c

Sync to master

557bb08

Merge pull request #4 from Azure/master

bf4d3c3

Sync to master

Remove stale files from sync

745b96d

Fix python warning from previous rrclient commit.

adea1da

Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.

Fix python warning from previous rrclient commit and move config hand…

cc133ea

…ling to a more relevant place for this cmd. Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.

Fix python warning from previous rrclient commit and move config hand…

d1e05d8

…ling to a more relevant place for this cmd. Add config support for nhopself, keepalive and holdtime timers. Add route-map to prefer global nexthops for ebgp learned prefixes.

Sync to master

f1eb735

Merge pull request #5 from Azure/master

4a1c7a0

Sync to master

Auto-completion, help (?), cmd navigation (up arrow) not working in v…

54e176f

…tysh on host system. RB= G=lnos-reviewers R=ntrianta,rjonnadu,rmolina,sfardeen,zxu A=

nikos-github mentioned this pull request Nov 10, 2017

Auto-completion, help (?), cmd navigation (up/down arrows) not working in vtysh on host system. sonic-net/sonic-quagga#19

Merged

Update sonic-quagga submodule

58082cd

lguohan merged commit f18ed0d into sonic-net:master Nov 13, 2017

stcheng added the Enhancement ➕ label Nov 13, 2017

Mrak-IW pushed a commit to Mrak-IW/sonic-buildimage that referenced this pull request Dec 11, 2017

[bgp]: Auto-completion, help (?), cmd navigation (up arrow) not worki…

9cc2f41

…ng in vtysh on host system. (sonic-net#1124)

lguohan pushed a commit that referenced this pull request Dec 11, 2017

[bgp]: Auto-completion, help (?), cmd navigation (up arrow) not worki…

fa8edce

…ng in vtysh on host system. (#1124) (#1227)

yxieca mentioned this pull request Apr 4, 2020

[201811][utilities] advance submodule heads #4368

Merged

dzhangalibaba mentioned this pull request Apr 20, 2020

[sonic-py-swsssdk/snmpagent] update submodule for sonic-py-swsssdk / snmpagent #4421

Merged

judyjoseph mentioned this pull request Apr 25, 2020

[Multi-ASIC] To pass the asic instance ID to orchagent, Advance the swss, swss-common submodules. #4465

Merged

yxieca mentioned this pull request Jul 9, 2020

[201811][swss] advance swss submodule head #4935

Merged

abdosi added a commit that referenced this pull request Sep 28, 2020

[Submodule update] sonic-utilities

0618319

Fix load minigraph on 201911 branch. (#1124) Fixed config load_minigrpah not working for Multi-asic platfroms. (#1123) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Auto-completion, help (?), cmd navigation (up arrow) not working in vtysh on host system. #1124

Auto-completion, help (?), cmd navigation (up arrow) not working in vtysh on host system. #1124

nikos-github commented Nov 7, 2017 •

edited

Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 •

edited

Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 •

edited

Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 •

edited

Loading

rodnymolina commented Nov 7, 2017

nikos-github commented Nov 7, 2017

nikos-github commented Nov 10, 2017

nikos-github commented Nov 10, 2017

nikos-github commented Nov 10, 2017

lguohan commented Nov 10, 2017

Auto-completion, help (?), cmd navigation (up arrow) not working in vtysh on host system. #1124

Auto-completion, help (?), cmd navigation (up arrow) not working in vtysh on host system. #1124

Conversation

nikos-github commented Nov 7, 2017 • edited Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 • edited Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 • edited Loading

lguohan commented Nov 7, 2017

nikos-github commented Nov 7, 2017 • edited Loading

rodnymolina commented Nov 7, 2017

nikos-github commented Nov 7, 2017

nikos-github commented Nov 10, 2017

nikos-github commented Nov 10, 2017

nikos-github commented Nov 10, 2017

lguohan commented Nov 10, 2017

nikos-github commented Nov 7, 2017 •

edited

Loading

nikos-github commented Nov 7, 2017 •

edited

Loading

nikos-github commented Nov 7, 2017 •

edited

Loading

nikos-github commented Nov 7, 2017 •

edited

Loading