Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Set default ACR in UpgrateVersion/PR/official pipeline. #10341

Merged
merged 9 commits into from
Apr 1, 2022

Conversation

liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Mar 24, 2022

Why I did it

docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it

Set DEFAULT_CONTAINER_REGISTRY in pipeline.

How to verify it

Log will print DEFAULT_CONTAINER_REGISTRY value.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@liushilongbuaa liushilongbuaa marked this pull request as ready for review March 24, 2022 09:26
@xumia
Copy link
Collaborator

xumia commented Mar 24, 2022

@liushilongbuaa , could you please update the PR title, description, and add tags?

xumia
xumia previously approved these changes Mar 25, 2022
@liushilongbuaa liushilongbuaa changed the title [ci] Set default ACR in UpgrateVersion pipeline in reproducible build. [ci] Set default ACR in UpgrateVersion/PR/official pipeline. Mar 29, 2022
@liushilongbuaa
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

xumia
xumia previously approved these changes Mar 31, 2022
xumia
xumia previously approved these changes Apr 1, 2022
@liushilongbuaa
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

1 similar comment
@liushilongbuaa
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xumia xumia merged commit 12cfb2b into sonic-net:master Apr 1, 2022
xumia pushed a commit that referenced this pull request Apr 2, 2022
Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit that referenced this pull request Apr 8, 2022
Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit that referenced this pull request Apr 8, 2022
Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
SuvarnaMeenakshi added a commit to SuvarnaMeenakshi/sonic-buildimage that referenced this pull request Apr 11, 2022
qiluo-msft added a commit to qiluo-msft/sonic-buildimage that referenced this pull request Apr 11, 2022
qiluo-msft added a commit that referenced this pull request Apr 12, 2022
…10341)" (#10535)

This reverts commit f4bbcd1. The original one was missing one file ".azure-pipelines/azure-pipelines-repd-build-variables.yml" and break the Azure pipeline.
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Apr 12, 2022
…et#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 2, 2022
…et#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 2, 2022
…et#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit to liushilongbuaa/sonic-buildimage that referenced this pull request Jun 2, 2022
…et#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.
liushilongbuaa added a commit that referenced this pull request Jun 22, 2022
* [ci] Set default ACR in UpgrateVersion/PR/official pipeline. (#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.

* Add a config variable to override default container registry instead of dockerhub. (#10166)
* Add variable to reset default docker registry
* fix bug in docker version control
StormLiangMS pushed a commit to StormLiangMS/sonic-buildimage that referenced this pull request Jul 18, 2022
…et#11002)

* [ci] Set default ACR in UpgrateVersion/PR/official pipeline. (sonic-net#10341)

Why I did it
docker hub will limit the pull rate.
Use ACR instead to pull debian related docker image.

How I did it
Set DEFAULT_CONTAINER_REGISTRY in pipeline.

* Add a config variable to override default container registry instead of dockerhub. (sonic-net#10166)
* Add variable to reset default docker registry
* fix bug in docker version control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants