Skip to content

Commit

Permalink
Remove buffer drop counter when port is removed (#1860)
Browse files Browse the repository at this point in the history
- What I did
I added the removal of port buffer drop counter on the deinit port flow.
it was added to the deInitPort function.

- Why I did it
the buffer drop counter was never removed when port was deleted.
this flex counter was create on the initPort function but it was removed when the port was deleted

- How I verified it
removed and created a port and check the FLEX_COUNTER redis table

FLEX_COUNTER_TABLE:PORT_BUFFER_DROP_STAT table
  • Loading branch information
tomer-israel committed Nov 15, 2021
1 parent f9462c4 commit 4912a77
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions orchagent/portsorch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2423,6 +2423,13 @@ void PortsOrch::deInitPort(string alias, sai_object_id_t port_id)
{
port_stat_manager.clearCounterIdList(p.m_port_id);
}

if (flex_counters_orch->getPortBufferDropCountersState())
{
port_buffer_drop_stat_manager.clearCounterIdList(p.m_port_id);
}


/* remove port name map from counter table */
m_counter_db->hdel(COUNTERS_PORT_NAME_MAP, alias);

Expand Down

0 comments on commit 4912a77

Please sign in to comment.