SONiC Security Auditing HLD #1713
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Jun 14, 2024
qiluo-msft
reviewed
Jun 14, 2024
qiluo-msft
reviewed
Jun 14, 2024
qiluo-msft
reviewed
Jun 14, 2024
maipbui
force-pushed
the
audit_enhancement
branch
from
fabe961
to
f8391bf
Compare
This was referenced Aug 1, 2024
Signed-off-by: Mai Bui <maibui@microsoft.com>
maipbui
force-pushed
the
audit_enhancement
branch
from
dea4ed5
to
f67c824
Compare
Signed-off-by: Mai Bui <maibui@microsoft.com>
qiluo-msft
reviewed
Aug 14, 2024
qiluo-msft
reviewed
Aug 14, 2024
qiluo-msft
reviewed
Aug 14, 2024
|
community review recording https://zoom.us/rec/share/I2O2drYuFPNLFyWGPanI_rQ7qPIOkyfa9yNyJSON7BxDbKWcshSltjHwfUueU_tN.EySn3jaIk96H4zXA |
qiluo-msft
reviewed
Aug 16, 2024
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
|
According to Sonic team and community's feedback, addressed and added some additional topics to the HLD
|
maipbui
requested review from
saiarcot895,
dgsudharsan,
yxieca and
venkatmahalingam
maipbui
requested review from
StormLiangMS,
xincunli-sonic,
prsunny and
lguohan
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
Signed-off-by: Mai Bui <maibui@microsoft.com>
qiluo-msft
reviewed
Sep 19, 2024
doc/audit/security_auditing_HLD.md
Outdated
| @@ -37,7 +37,7 @@ | |||
| ## List of Tables | |||
| * [Table 1: Revision](#table-1-revision) | |||
| * [Table 2: Audit Rules Review](#table-2-audit-rules-review) | |||
| * [Table 3: Unit Test Cases](#table-3-unit-test-cases) | |||
| * [Table 3: Unt Test Cases](#table-3-unit-test-cases) | |||
qiluo-msft
reviewed
Sep 19, 2024
doc/audit/security_auditing_HLD.md
Outdated
| ] | ||
| } | ||
| ] | ||
| "critical_files": "enabled", |
There was a problem hiding this comment.
For ConfigDB, the word convention is enable/disable
For StateDB, the word convention is enabled/disabled. #Closed
Signed-off-by: Mai Bui <maibui@microsoft.com>
|
@liuh-80 @Yarden-Z @xincunli-sonic @venkatmahalingam @yxieca @prsunny @lguohan @StormLiangMS could you please help review the HLD? thanks |
This reverts commit 9750acb.
Signed-off-by: Mai Bui <maibui@microsoft.com>
qiluo-msft
previously approved these changes
Sep 20, 2024
xincunli-sonic
previously approved these changes
Sep 20, 2024
Signed-off-by: Mai Bui <maibui@microsoft.com>
maipbui
dismissed stale reviews from xincunli-sonic and qiluo-msft
via
b59f532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This design aims to enhance the auditing capabilities within SONiC operating system using audit daemon (auditd). Auditing is the process of recording and analyzing the events that occur on the device. Auditing can help to detect unauthorized access, configuration changes, malicious activity, or system errors. Auditing can also provide evidence for forensic investigations, compliance audits, or incident response.