-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-58499: poc for backward compatibility for solarwinds_apm #74
Conversation
Based on conversation, we only reserve the backward/feature of custom metrics. |
Thanks @xuan-cao-swi. It looks like the custom metrics methods are exposed under
|
One more ask: playing around with
|
It seems like the error checking logic is wrong. 0 should be successful |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @xuan-cao-swi!
Based on the https://rubydoc.info/gems/solarwinds_apm/SolarWindsAPM/SDK, create opentelemetry-ruby compatible function for custom_metrics as vendor-provided function.
I tested with following scripts
More ad-hoc test will be in testbed