Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-85973 instrument function handler dependencies #141

Closed
wants to merge 1 commit into from

Conversation

cheempz
Copy link
Contributor

@cheempz cheempz commented Jul 24, 2024

Description

From Jira discussion it seems possible to try loading the original handler file (causing all function dependencies to also be loaded), then load solarwinds_apm which will bootstrap instrumentations based on loaded libraries.

This is a POC for how we might use the existing OTel Lambda Handler instrumentation's resolve_original_handler on initialization to achieve the loading.

Test (if applicable)

Quick test with this change and a function that requires the aws-sdk-lambda gem has this in CW log:
I, [2024-07-24T23:09:51.172528 #15] INFO -- : Instrumentation: OpenTelemetry::Instrumentation::AwsSdk was successfully installed with the following options {:inject_messaging_context=>false, :suppress_internal_instrumentation=>false}

Unfortunately I'm still not getting the AWS SDK span, maybe due to span context issue that would be fixed by open-telemetry/opentelemetry-ruby-contrib#1073

@cheempz cheempz changed the title Update otel_wrapper.rb NH-85973 instrument function handler dependencies Jul 24, 2024
@cheempz cheempz closed this Aug 1, 2024
@cheempz
Copy link
Contributor Author

cheempz commented Aug 1, 2024

Will be in new PR off of https://github.com/solarwinds/apm-ruby/tree/NH-85973

@cheempz cheempz deleted the NH-85973-load-solarwinds-last branch August 1, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant