NH-71431: refactor log msg and remove unused code #115
Conversation
| end |
There was a problem hiding this comment.
I don't know why github auto-remove the newline...
lib/solarwinds_apm.rb
Outdated
|
|
||
| SolarWindsAPM.logger.info '===================================================================' | ||
| SolarWindsAPM.logger.info "SolarWindsAPM info: Platform #{RUBY_PLATFORM}." | ||
| SolarWindsAPM.logger.info "Current solarwinds_apm version: #{SolarWindsAPM::Version::STRING}" |
There was a problem hiding this comment.
Is it possible to also detect and log out the OTel API/SDK versions (and possibly the instrumentation-all version) installed, seems useful for troubleshooting.
There was a problem hiding this comment.
added. also updated the test page.
===================================================================
I, [2024-02-05T07:20:09.144844 #507] INFO -- : Ruby 3.1.0 on platform aarch64-linux.
I, [2024-02-05T07:20:09.144853 #507] INFO -- : Current solarwinds_apm version: 6.0.0.prev7.
I, [2024-02-05T07:20:09.144859 #507] INFO -- : OpenTelemetry version: 1.3.1.
I, [2024-02-05T07:20:09.144872 #507] INFO -- : OpenTelemetry instrumentation version: 0.56.0.
===================================================================
lib/solarwinds_apm.rb
Outdated
| require_relative './oboe_metal' # initialize reporter: SolarWindsAPM.loaded = true | ||
|
|
||
| SolarWindsAPM.logger.info '===================================================================' | ||
| SolarWindsAPM.logger.info "SolarWindsAPM info: Platform #{RUBY_PLATFORM}." |
There was a problem hiding this comment.
Can we also add a log message about the Ruby version?
There was a problem hiding this comment.
Thanks for the testing results page @xuan-cao-swi! Great to keep cleaning up the unused code, I left some comments on the log messgaes.
| require 'solarwinds_apm/config' | ||
|
|
||
| SolarWindsAPM::Config.load_config_file | ||
| SolarWindsAPM.loaded = false |
There was a problem hiding this comment.
It seems safer to keep this initialization of loaded to false, any reason to remove?
There was a problem hiding this comment.
yeah, I changed the structure of SolarWindsAPM module (oboe_metal.rb) that initialize the loaded as false; so its default will be false as always. It will change to true once reporter initialization process finished without any issue.
Co-authored-by: Lin Lin <lin.lin@solarwinds.com>
Description
Test (if applicable)