token 2022: add `InitializeGroup` instruction from SPL Token Group interface #5601

buffalojoec · 2023-10-18T13:45:23Z

This PR adds the InitializeGroup instruction to Token2022 - from the SPL Token Group interface.

buffalojoec · 2023-10-18T13:45:41Z

Current dependencies on/for this PR:

master
- PR token 2022: add alloc_and_serialize for fixed-len extensions #5672
  - PR token 2022: add InitializeGroup instruction from SPL Token Group interface #5601 👈
    - PR token 2022: add UpdateGroupMaxSize instruction from SPL Token Group interface #5626
      - PR token 2022: add UpdateGroupAuthority instruction from SPL Token Group interface #5627
        
        PR token 2022: add support for _reading_ repeating fixed-length extensions #5836
        
        PR token 2022: add support for _writing_ repeating fixed-length extensions #5837
        
        PR token 2022: add support for additional signers in test init functions #5838
        
        PR token 2022: add GroupMemberPointer extension #5628
        
        PR token 2022: add alloc_and_serialize_allow_repeating #5839
        PR token 2022: add InitializeMember instruction from SPL Token Group interface #5629

This stack of pull requests is managed by Graphite.

token/program-2022/src/extension/token_group/processor.rs

joncinque

Looks great for the most part! Just the one bit about realloc, wondering if we can tighten that up some more

token/program-2022/src/extension/token_group/processor.rs

token/program-2022/src/extension/mod.rs

token/program-2022-test/tests/token_group_initialize.rs

token/client/src/token.rs

…terface

joncinque

Looks great! Let's get the groups going

joncinque · 2023-11-09T11:58:56Z

token/client/src/token.rs

+    }
+
+    /// Initialize token-group on a mint
+    #[allow(clippy::too_many_arguments)]


micro-nit: I think clippy allows up to 7 args, so this shouldn't be needed

What the 🤨
I think I had another arg in here or something. Changed!

joncinque · 2023-11-09T12:00:14Z

token/client/src/token.rs

+        if mint_state.get_extension::<V>().is_ok() {
+            Ok(0)
+        } else {
+            let new_account_len = mint_state.try_get_new_account_len::<V>()?;


very neat 😎

Pull request has been modified.

This was referenced Oct 18, 2023

token group: init interface #5512

Merged

token-group: create example program #5548

Merged

token-group: create editions example #5549

Closed

token 2022: add support for groups #5593

Closed

token 2022: move update authority check to shared file #5595

Closed

buffalojoec mentioned this pull request Oct 18, 2023

token 2022: make IncorrectMintAuthority a TokenError #5596

Closed

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 5b340e5 to dbd9ef8 Compare October 18, 2023 13:48

buffalojoec force-pushed the 10-18-token_2022_make_IncorrectMintAuthority_a_TokenError_ branch from 82f3418 to 31ee52e Compare October 18, 2023 13:50

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from dbd9ef8 to 834d4a3 Compare October 18, 2023 13:50

This was referenced Oct 19, 2023

token collection: create spec program #5614

Merged

token metadata: replace IncorrectMintAuthority with TokenError::OwnerMismatch #5615

Closed

buffalojoec changed the base branch from 10-18-token_2022_make_IncorrectMintAuthority_a_TokenError_ to 10-20-token_2022_add_GroupPointer_extension October 20, 2023 10:54

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 834d4a3 to 92b33dc Compare October 20, 2023 10:54

This was referenced Oct 20, 2023

token group: add mint to interface #5616

Merged

token 2022: add GroupPointer extension #5621

Merged

buffalojoec force-pushed the 10-20-token_2022_add_GroupPointer_extension branch from 2c5bf6c to c4a0ffa Compare October 20, 2023 10:56

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 92b33dc to 35b6a07 Compare October 20, 2023 10:56

buffalojoec force-pushed the 10-20-token_2022_add_GroupPointer_extension branch from c4a0ffa to 1b7a918 Compare October 20, 2023 11:33

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch 2 times, most recently from d942fb4 to ecba134 Compare October 20, 2023 11:38

buffalojoec marked this pull request as ready for review October 20, 2023 11:38

buffalojoec force-pushed the 10-20-token_2022_add_GroupPointer_extension branch 2 times, most recently from c5d4211 to 260e7b2 Compare October 21, 2023 07:19

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch 3 times, most recently from 3860a11 to 8080c30 Compare October 21, 2023 14:29

This was referenced Oct 21, 2023

token 2022: add UpdateGroupMaxSize instruction from SPL Token Group interface #5626

Merged

token 2022: add UpdateGroupAuthority instruction from SPL Token Group interface #5627

Merged

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 8080c30 to 17677bf Compare October 21, 2023 14:55

buffalojoec requested a review from joncinque October 24, 2023 12:07

buffalojoec commented Oct 24, 2023

View reviewed changes

token/program-2022/src/extension/token_group/processor.rs Outdated Show resolved Hide resolved

joncinque reviewed Oct 24, 2023

View reviewed changes

token/program-2022/src/extension/token_group/processor.rs Outdated Show resolved Hide resolved

token/program-2022/src/extension/mod.rs Show resolved Hide resolved

token/program-2022-test/tests/token_group_initialize.rs Outdated Show resolved Hide resolved

joncinque reviewed Oct 25, 2023

View reviewed changes

token/client/src/token.rs Outdated Show resolved Hide resolved

buffalojoec changed the base branch from master to 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions October 26, 2023 14:25

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from aa4c6d4 to 01f924d Compare October 26, 2023 14:25

buffalojoec mentioned this pull request Oct 26, 2023

token 2022: add alloc_and_serialize for fixed-len extensions #5672

Merged

buffalojoec force-pushed the 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions branch from 3ee9e63 to 6f83fe0 Compare October 26, 2023 14:32

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 01f924d to ff6ce5b Compare October 26, 2023 14:32

buffalojoec force-pushed the 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions branch from 6f83fe0 to 878e601 Compare October 26, 2023 15:02

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from ff6ce5b to 837a1a0 Compare October 26, 2023 15:02

buffalojoec force-pushed the 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions branch from 878e601 to a29209e Compare October 26, 2023 15:23

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 837a1a0 to b31b5d0 Compare October 26, 2023 15:23

buffalojoec force-pushed the 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions branch from 318e54b to 0509e06 Compare November 6, 2023 20:57

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from b31b5d0 to 629e2c2 Compare November 6, 2023 20:57

Base automatically changed from 10-26-token_2022_add_alloc_and_serialize_for_fixed-len_extensions to master November 8, 2023 08:57

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from 629e2c2 to e7fb59c Compare November 8, 2023 08:59

buffalojoec added 2 commits November 9, 2023 09:13

token 2022: add InitializeGroup instruction from SPL Token Group in…

f41e9d8

…terface

feedback: rework rent check and test tx dedupe

3a0de2e

buffalojoec force-pushed the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch from e7fb59c to 3a0de2e Compare November 9, 2023 09:13

joncinque previously approved these changes Nov 9, 2023

View reviewed changes

clip clip clippy

74a8359

joncinque approved these changes Nov 9, 2023

View reviewed changes

buffalojoec merged commit a019dcc into master Nov 9, 2023
34 checks passed

buffalojoec deleted the 10-18-token_2022_add_InitializeGroup_instruction_from_SPL_Token_Group_interface branch November 9, 2023 13:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

token 2022: add `InitializeGroup` instruction from SPL Token Group interface #5601

token 2022: add `InitializeGroup` instruction from SPL Token Group interface #5601

buffalojoec commented Oct 18, 2023 •

edited

Loading

buffalojoec commented Oct 18, 2023 •

edited

Loading

joncinque left a comment

joncinque left a comment

joncinque Nov 9, 2023

buffalojoec Nov 9, 2023

joncinque Nov 9, 2023

token 2022: add InitializeGroup instruction from SPL Token Group interface #5601

token 2022: add InitializeGroup instruction from SPL Token Group interface #5601

Conversation

buffalojoec commented Oct 18, 2023 • edited Loading

buffalojoec commented Oct 18, 2023 • edited Loading

joncinque left a comment

Choose a reason for hiding this comment

joncinque left a comment

Choose a reason for hiding this comment

joncinque Nov 9, 2023

Choose a reason for hiding this comment

buffalojoec Nov 9, 2023

Choose a reason for hiding this comment

joncinque Nov 9, 2023

Choose a reason for hiding this comment

token 2022: add `InitializeGroup` instruction from SPL Token Group interface #5601

token 2022: add `InitializeGroup` instruction from SPL Token Group interface #5601

buffalojoec commented Oct 18, 2023 •

edited

Loading

buffalojoec commented Oct 18, 2023 •

edited

Loading