token-2022(feat): add serialisation option for the extensions #5437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
mergify
bot
dismissed
buffalojoec’s stale review
Pull request has been modified.
joncinque
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Looks great, thanks! If you're interested in doing the zk bits, you'll find those types at https://github.com/solana-labs/solana/tree/master/zk-token-sdk
ghost
mentioned this pull request
Done: solana-labs/solana#33760 |
ghost
deleted the
joncinque
reviewed
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5431
Note that for extension
confidentional_transferandconfidential_transfer_fee, some the fields are in a separate sdk which doesn't have the serialisation enabled. We would have to change there first before setting it hereTested by turning on the compile time flags
serde-traitby default and using it in our codebase.