improve performance of multiidx2n #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vsoftco, is there anything else that needs to be addressed for the p.r ? |
|
Thanks Saman, looks good just doing some testing on our end, we’ll be in touch shortly!
From: Saman ***@***.***>
Date: Monday, May 6, 2024 at 8:23 AM
To: softwareQinc/qpp ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [softwareQinc/qpp] improve performance of multiidx2n (PR #173)
Hi @vsoftco<https://github.com/vsoftco>, is there anything else that needs to be addressed for the p.r ?
—
Reply to this email directly, view it on GitHub<#173 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEOM6IKKK7QX3E367TCNH6TZA5Y23AVCNFSM6AAAAABHFK66BGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJVHA4TIOBUHA>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
vsoftco
requested changes
May 6, 2024
There was a problem hiding this comment.
@enum-class Can you please re-write L113 as part_prod *= dims[numdims-1];? Other than that, all looks good, I'll merge it once the modification. Thanks!
|
@vsoftco @jimlambert thanks, I have done it |
vsoftco
added a commit
that referenced
this pull request
Jul 29, 2024
* WIP * Simplified MATLAB detection * Update CHANGES.md * Formatting * Minor update POSIX-compliance Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * add .txt extension VERSION conflicts with cpp20 <version> on macOS, hence renamed to VERSION.txt Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * fix Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Minor update Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * improve performance of multiidx2n (#173) * improve performance of multiidx2n * minor cleanup * minor fix * CCNOT example (#175) * add toffoli example * fix typo * Updated CCNOT example Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> * Minor typos Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> --------- Signed-off-by: Vlad Gheorghiu <vsoftco@gmail.com> Co-authored-by: Saman <100295082+enum-class@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance of multiidx2n function, which exist in the hot pass.