Android crash / NullPointerException #2477

mikehardy · 2021-10-01T03:26:24Z

For some reason, in android release builds on my app (or debug builds if I configure minifyEnabled true for debug buildType) this crashes on this line (I carefully deobfuscated the stack trace, and it's definitely crashing here - no idea why minify triggers it when it's not the classic ClassNotFoundException or NoClassDef etc that proguard would normally throw)

09-30 22:08:02.832  8709  8709 E unknown:ReactNative: Exception in native call
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: java.lang.NullPointerException: Attempt to invoke virtual method 'java.lang.Object java.util.HashMap.get(java.lang.Object)' on a null object reference
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at h5.f.r(:218)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.z0$m.a(:217)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.z0$a.run(:915)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.z0.U(:1026)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.z0.s(:47)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.z0$j.c(:1086)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.uimanager.f.a(:29)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.modules.core.g$d.a(:175)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.facebook.react.modules.core.a$a$a.doFrame(:85)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:970)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.view.Choreographer.doCallbacks(Choreographer.java:796)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.view.Choreographer.doFrame(Choreographer.java:727)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:957)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.os.Handler.handleCallback(Handler.java:938)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.os.Handler.dispatchMessage(Handler.java:99)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.os.Looper.loop(Looper.java:223)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at android.app.ActivityThread.main(ActivityThread.java:7656)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at java.lang.reflect.Method.invoke(Native Method)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
09-30 22:08:02.832  8709  8709 E unknown:ReactNative: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

And the relevant portion of android/app/build/outputs/mapping/debug/mapping.txt showing what h5.f.r is:


com.swmansion.reanimated.layoutReanimation.ReanimatedNativeHierarchyManager -> h5.f:
    java.util.HashMap cleanerCallback -> n
    java.util.HashMap toBeRemoved -> m
    com.facebook.react.uimanager.layoutanimation.LayoutAnimationController mReaLayoutAnimator -> o
    java.util.HashMap mPendingDeletionsForTag -> p
    134:163:void <init>(com.facebook.react.uimanager.ViewManagerRegistry,com.facebook.react.bridge.ReactApplicationContext) -> <init>
    169:178:void updateLayout(int,int,int,int,int,int) -> C
    234:235:void publicDropView(android.view.View) -> G
    238:250:void dropView(android.view.View) -> n
    181:231:void manageChildren(int,int[],com.facebook.react.uimanager.ViewAtIndex[],int[]) -> r

So it's in ReanimatedNativeHierarchyManager::manageChildren on line 218 - right where mPendingDeletionsForTag is dereferenced for a .get with no null check.

I believe that since mPendingDeletionsForTag is initialized to null, and only set to a valid HashMap in one of the constructors but not the other, I must be using the other constructor in my app.

Then when this line is hit, I get a null pointer exception.

I think this whole chunk could be wrapped in an if (mPendingDeletionsForTag != null) { /* ... */ }

Originally posted by @mikehardy in #2437 (comment)

The text was updated successfully, but these errors were encountered:

mikehardy · 2021-10-01T03:29:13Z

Please see the linked comment for the exact line of code - I highlighted it on the PR where it went in - #2437

The crash was observed using reanimated v2.3.0-beta.2 (just released) in combination with react-native 0.66.0-rc.4 as I was checking the release build that combo produced.

I was able to reproduce it using my app (which is not terribly fancy) by setting minifyEnabled true, so it should be pretty easy to reproduce, but at the same time I think my analysis of the NullPointerException is pretty easy to follow?

I can try to pull one of the examples here and set it up for repro if needed though

mikehardy · 2021-10-01T13:48:48Z

It occurs to me that the reason this likely crashes on boot is that the first thing my app does is load up a react-navigation tab set which is thus transitively dependent on reanimated

This example would serve but it's pretty stale on react-native + reanimated https://github.com/react-navigation/react-navigation/blob/fa45dde59b0c2e386280f00ad08393881539c16d/example/package.json#L31-L36

jacow · 2021-10-04T07:12:55Z

It occurs to me that the reason this likely crashes on boot is that the first thing my app does is load up a react-navigation tab set which is thus transitively dependent on reanimated

This example would serve but it's pretty stale on react-native + reanimated https://github.com/react-navigation/react-navigation/blob/fa45dde59b0c2e386280f00ad08393881539c16d/example/package.json#L31-L36

It also happened on me, i'm also using react nativagtion with bottom tab. Do you already found the solution ?

ruairioliverwv · 2021-10-04T10:57:17Z

I was able to get around this error by downgrading to v2.2.2 and building the aar for RN 0.66 from that tag.

Archive.zip

mikehardy · 2021-10-04T16:31:37Z

Yes, I proposed PR #2478 and I have build the 2.3.0-beta AAR for react-native-66-hermes locally. In a package-json post-install script I copy that AAR into place (over the existing one) and it runs perfectly. Just waiting for review on #2478. I'll attach the AAR I use here

mikehardy · 2021-10-04T16:33:22Z

react-native-reanimated 2.3.0-beta (that is, from dev branch on 2021/09/30) ~~react-native-reanimated-66-hermes.aar.zip~~ (note! it's actually just an .aar file that I renamed by adding .zip to it so GitHub would let me attach it. Rename it after download by just removing .zip from the end of the filename)(note2: grab the updated AAR I attached below 👇 )

    "postinstall": "patch-package && cp patches/react-native-reanimated-66-hermes.aar node_modules/react-native-reanimated/android/",

…imator (#2478) ## Description mPendingDeletionsForTag is only initialized in some constructor paths, in others it might be null, so we cannot always blindly dereference it Fixes #2477 ## Test code and steps to reproduce For me, I'm able to reproduce a crash here anytime minifyEnabled is true in my build (you can set it in debug, to check it), and it crashes on startup for me.

pang0018 · 2021-10-06T20:38:30Z

@mikehardy the zipped aar file cannot unzipped on my mac. See below Any change we get an updated beta soon instead?

mikehardy · 2021-10-06T21:11:39Z

It's not actually a zip, sorry. It is literally just the .aar file with .zip added to it because GitHub will simply not allow you to attach an .aar (which is...technically a zip 😆 ) but it will allow a .zip. I'll amend my instructions. You can try unzip -l react-native-reaniminated-66-hermes.aar.zip on command line (-l is just "list", it's safe, or should be) to verify if you like

mikehardy · 2021-10-08T22:07:23Z

With sincere apologies I realize the aar I packed up and attached above does not contain the actual class that I fixed in the related PR. Why is that? Because in order to really test the fix I removed those exact classes from the aar and worked on the java file in my own app's source tree. I got it working then of course forgot to put them back in the AAR I put here. So if anyone tried to use it before, you would have crashed on startup with a NoClassDefFoundError on ReanimatedNativeHierarchyManager.

I've put the classes in their rightful home in the AAR here and I'm re-attaching it. I only noticed myself when I went to take my own fix and put it in another app and couldn't realize why it was crashing !?!. Apologies

react-native-reanimated-66-hermes.aar.zip

StevenJPx2 · 2022-01-18T10:10:39Z

@mikehardy I'm still getting this issue with 2.3.1. Do I downgrade to 2.3.0-beta and apply the patch?

mikehardy · 2022-01-18T12:12:36Z

This was fixed and released in the related PR. You may have a different problem, I would open a new ticket. You may also try react-native-clean-project

StevenJPx2 · 2022-01-19T14:51:38Z

I found what the issue was. The hardware acceleration requirement for reanimated doesn't play well with Flipper. While using Flipper to debug, it is fine, but when you quit Flipper while the debug version is running, it has an inadvertent crash.

Is this a fixable issue?

mikehardy · 2022-01-19T14:56:30Z

I would definitely open a separate ticket for that with related information (stack trace from adb logcat etc, versions in play, exact steps to reproduce). It is not related to this issue

mikehardy · 2022-01-19T14:57:01Z

separately: wow, subtle interaction there, and I don't use flipper to debug, explains why it does not happen to me

mikehardy mentioned this issue Oct 1, 2021

fix(android): avoid using null mPendingDeletionsForTag / mReaLayoutAnimator #2478

Merged

6 tasks

ruairioliverwv mentioned this issue Oct 4, 2021

[2.3.0-beta.1] React-Navigation Back Button unmounts previous screen with Reanimated #2460

Closed

3 tasks

Szymon20000 closed this as completed in #2478 Oct 5, 2021

savv mentioned this issue Oct 12, 2021

The specified child already has a parent (when using with react-navigation) #2501

Closed

3 tasks

mikehardy mentioned this issue Oct 12, 2021

App build fails on iOS 14.5 mixpanel/mixpanel-react-native#43

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android crash / NullPointerException #2477

Android crash / NullPointerException #2477

mikehardy commented Oct 1, 2021 •

edited

Loading

mikehardy commented Oct 1, 2021

mikehardy commented Oct 1, 2021

jacow commented Oct 4, 2021

ruairioliverwv commented Oct 4, 2021

mikehardy commented Oct 4, 2021 •

edited

Loading

mikehardy commented Oct 4, 2021 •

edited

Loading

pang0018 commented Oct 6, 2021

mikehardy commented Oct 6, 2021

mikehardy commented Oct 8, 2021

StevenJPx2 commented Jan 18, 2022

mikehardy commented Jan 18, 2022

StevenJPx2 commented Jan 19, 2022

mikehardy commented Jan 19, 2022

mikehardy commented Jan 19, 2022

Android crash / NullPointerException #2477

Android crash / NullPointerException #2477

Comments

mikehardy commented Oct 1, 2021 • edited Loading

mikehardy commented Oct 1, 2021

mikehardy commented Oct 1, 2021

jacow commented Oct 4, 2021

ruairioliverwv commented Oct 4, 2021

mikehardy commented Oct 4, 2021 • edited Loading

mikehardy commented Oct 4, 2021 • edited Loading

pang0018 commented Oct 6, 2021

mikehardy commented Oct 6, 2021

mikehardy commented Oct 8, 2021

StevenJPx2 commented Jan 18, 2022

mikehardy commented Jan 18, 2022

StevenJPx2 commented Jan 19, 2022

mikehardy commented Jan 19, 2022

mikehardy commented Jan 19, 2022

mikehardy commented Oct 1, 2021 •

edited

Loading

mikehardy commented Oct 4, 2021 •

edited

Loading

mikehardy commented Oct 4, 2021 •

edited

Loading