Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show current round instead of current turn #27

Closed
SKoschnicke opened this issue Sep 24, 2020 · 2 comments · Fixed by #61
Closed

Show current round instead of current turn #27

SKoschnicke opened this issue Sep 24, 2020 · 2 comments · Fixed by #61
Labels
enhancement New feature or request

Comments

@SKoschnicke
Copy link
Contributor

Because we have a round limit, this information is important to the player.
@SKoschnicke SKoschnicke added the enhancement New feature or request label Sep 24, 2020
@SKoschnicke SKoschnicke changed the title Show current round additionally to current turn Show current round instead of current turn Nov 2, 2020
@SKoschnicke
Copy link
Contributor Author

Also, the turn-count can confuse the user. If a color can't place a piece anymore, it is skipped and that doesn't count as turn anymore. So rounds have fewer turns in the later game and the sum of turns can be less than 25 * 4.

@anarchuser is there a way to get the current round? Seems like it can't be calculated from the current turn.

@anarchuser
Copy link
Contributor

GameState has a round property which keeps track of the current round

xeruf added a commit that referenced this issue Jan 19, 2021
@xeruf
feat(view/StatusView): show round instead of turn
ac1ef49 
Fixes #27
@xeruf xeruf mentioned this issue Jan 19, 2021
Merged
@xeruf xeruf closed this as completed in #61 Jan 20, 2021
xeruf added a commit that referenced this issue Jan 20, 2021
@xeruf
feat(view/StatusView): show round instead of turn
ee6f677 
Fixes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StatusView: Show round instead of turn & player name instead of team name software-challenge/gui
2 participants
@SKoschnicke @anarchuser