-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
base: feedback
Are you sure you want to change the base?
Feedback #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done, nearly finished. Try to fix the remaining bugs.
@@ -1,16 +1,27 @@ | |||
// ### LEVEL 1: The Basics ### | |||
export function add(x: number, y: number): number { | |||
// TODO: Return the sum of x and y | |||
throw new Error("Not implemented"); | |||
return x + y; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you Rainer!
src/math.ts
Outdated
// TODO: Return Fizz if value is divisible by 3, Buzz if value is divisible by 5, | ||
// FizzBuzz if value is divisible by 3 and 5, and the value as a string otherwise | ||
throw new Error("Not implemented"); | ||
if (value / 3 === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip: Use modulo (%) instead of division (/)
src/math.ts
Outdated
// FizzBuzz if value is divisible by 3 and 5, and the value as a string otherwise | ||
throw new Error("Not implemented"); | ||
if (value / 3 === 0) { | ||
if (value / 5 === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
src/math.ts
Outdated
return "Fizz"; | ||
} | ||
|
||
if (value / 5 === 0) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
main
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @jetzlstorfer