Async/Await Support (continuation of #191) #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for moving this forward! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Continuation of #191 that has been brought up to date with master. Most of the work in upgrading to hyper 0.13, tokio 0.2, and async/await syntax was done by @danieleades. I just merged with master, fixed merge conflicts, and sprinkled some
Sends around soContainer::attach()could be used inasync_traittraits.Closes: #185
Replaces: #191
References: #226
Closes: #228
How did you verify your change:
I ran the tests, ran clippy, got the CI to pass, and successfully integrated this into my WIP project.
What (if anything) would need to be called out in the CHANGELOG for the next release:
This is a change to support async/await syntax. It is a BREAKING CHANGE.