Fix setuptools version for install failure #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-v
force-pushed
the
fix_setuptools_ver
branch
2 times, most recently
from
3d1e8fb
to
614f1e5
Compare
joseph-v
force-pushed
the
fix_setuptools_ver
branch
from
614f1e5
to
6553aea
Compare
sushanthakumar
approved these changes
Feb 17, 2023
anvithks
approved these changes
Feb 17, 2023
| sudo apt-get install -y python3-distutils python3-testresources python3-pip | ||
| python3 -m pip install -U pip | ||
|
|
||
| # Update setuptool version if it is higher than 65 |
There was a problem hiding this comment.
nit: A detailed comment as to why this is being done will help any one looking at the code.
// Downgrade the setuuptools version to 65 if it is higher to prevent breaking changes (or whatever the reason is)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to ensure installed setuptools version, which is compatible with other modules of the project.
If setuptools version is higher than 65, downgrade it to 65
What type of PR is this?
What this PR does / why we need it:
Latest version of Python3 module
setuptoolsis not compatible pip module and causes install failure when pip is usedWhich issue(s) this PR fixes:
Fixes #510
Test Report Added?:
Test Report:
Special notes for your reviewer: