Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document update for readme to add example for strato(multi-cloud) also #508

Merged
merged 4 commits into from
Jan 9, 2023

Conversation

josephjacobmorris
Copy link
Contributor

@josephjacobmorris josephjacobmorris commented Dec 23, 2022

What type of PR is this?

/kind documentation

What this PR does / why we need it:
Increases readability of documentation and provides more examples to new user
Which issue(s) this PR fixes:

Fixes #

Test Report Added?:

/kind TESTED

Test Report:

  • Strato installation example added in readme
    image
  • Delfin installation example updated
    image

Special notes for your reviewer:

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@joseph-v joseph-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anvithks
Copy link
Member

@joseph-v We have the same installation steps on the documentation website where we have made changes and also updated the language. Would it be better to link to that document so that it is easier to maintain? Else we will have to keep updating both locations.

Copy link

@PravinRanjan10 PravinRanjan10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@skdwriting skdwriting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skdwriting skdwriting merged commit 73b78a4 into sodafoundation:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants