Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue loading both nio and nio4r gems #302

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

iterateNZ
Copy link
Contributor

@iterateNZ iterateNZ commented Aug 11, 2023

I've got an older application that uses the nio gem https://rubygems.org/gems/nio.

While updating to use puma I hit uninitialized constant NIO (NameError) as an error as the Nio constant is loaded first.

This change allows loading nio4r explicitly.

gem 'nio', '~> 0.2.5'
gem 'nio4r', require: 'nio4r'
gem 'puma'

@ioquatix
Copy link
Member

This seems reasonable to me.

@ioquatix ioquatix enabled auto-merge (squash) August 12, 2023 03:13
@ioquatix ioquatix merged commit d9682cf into socketry:main Aug 12, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants