Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NodeNext module resolution compatibility #669

Merged
merged 2 commits into from
Feb 17, 2023

Conversation

igorls
Copy link
Contributor

@igorls igorls commented Feb 9, 2023

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behavior

Types are not found when typescript moduleResolution is set to NodeNext, issue socketio/socket.io#4621

New behavior

Works normally with NodeNext

Other information (e.g. related issues)

Must be merged together with the socket.io PR socketio/socket.io#4625

@darrachequesne darrachequesne merged commit 6e78489 into socketio:main Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants