Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next engine.io release? #402

Closed
yasserf opened this issue Jun 17, 2016 · 2 comments
Closed

Next engine.io release? #402

yasserf opened this issue Jun 17, 2016 · 2 comments

Comments

@yasserf
Copy link

yasserf commented Jun 17, 2016

Wondering when the next release is, as I'm keen to start using the uws integration that has been merged early last month.

@kapouer
Copy link
Contributor

kapouer commented Jun 17, 2016

You can actually start using uws integration right now, please read the UWS readme about socket.io.

No reason to rush things ! i would find it a thousand times better if engine.io had an optional dependency on uws by default and kept a dependency on ws, and tried to load the uws module first and fallback to ws.
I think it's a little bit too soon to do that, though. The experience might be disappointing to the conservative user, but seeing how @alexhultman maintains uWebSocket, there is no doubt that in a few uws releases, engine.io should try using uws first in a default install.
Also i find it a little hypocrit to "leave the door open to other ws implementations" - there is little chance we see a lot of well-maintained websocket implementations... yes i mean that my PR #390 wasn't really a good idea.

@yasserf
Copy link
Author

yasserf commented Jun 18, 2016

Thanks for the quick reply! I could see that I could override websocketServer with the uwS one. The only thing that's slightly annoying is that it would create a ws sever first and then I'll override it, but I'll certainly be able to work around that.

I think having an optional dependency makes alot more sense, for those where node-gyp isn't installed having uws not optional would result in a headache for some window users and node-gyp.

@yasserf yasserf closed this as completed Jun 18, 2016
darrachequesne pushed a commit that referenced this issue May 8, 2020
Also remove duplicate deps and re-add component-inherit

Closes #384, closes #358, closes #348, closes #402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants