Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added required permissions in the action example #79

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danacr
Copy link

@danacr danacr commented Jan 26, 2022

The action example will fail without setting the read permission for the repository and the security events write for the Sarif file.

@danacr danacr requested a review from a team as a code owner January 26, 2022 18:46
@nathanpVuka
Copy link

I had to add other permissions in order to get them to actually work:

    permissions:
      actions: read
      contents: read
      statuses: read
      security-events: write

@jahow
Copy link

jahow commented Apr 24, 2023

Hi,

Just pointing out that this PR is quite important IMO, I've been struggling with permissions and couldn't find anything to help me in all of Snyk docs, so this change would probably very much appreciated!

thanks for the great project!

Copy link
Contributor

@michelkaporin michelkaporin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a PR, please rebase & re-run the generator, then we can merge this in 👍

_templates/README.md.erb Show resolved Hide resolved
@huyz
Copy link

huyz commented Aug 7, 2023

Why is there no Issues tab on this repo?

Is the PR area the only place where we can tell you that things don't work?

@huyz
Copy link

huyz commented Aug 7, 2023

Sorry to hijack this PR for my issue. I just don't see where to report problems for this repo.

Has anyone been able to get the snyk/snyk:python action to work? No matter what I do, I get:

`snyk` requires an authenticated account. Please run `snyk auth` and try again.

even though my SNYK_TOKEN secret is set in the repo and I have:

    steps:
      - uses: actions/checkout@v3
      - name: Run Snyk to check configuration files for security issues
        uses: snyk/actions/python@master
        # Snyk can be used to break the build when it detects security issues.
        # In this case we want to upload the issues to GitHub Code Scanning
        continue-on-error: true
        env:
          # In order to use the Snyk Action you will need to have a Snyk API token.
          # More details in https://github.com/snyk/actions#getting-your-snyk-token
          # or you can signup for free at https://snyk.io/login
          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
        with:
          #args: --severity-threshold=high
          args: --sarif-file-output=snyk.sarif

This used to work months ago, but it's stopped working for months now. (And I'm wondering if Snyk has CI on their own actions 😄 )

@michelkaporin
Copy link
Contributor

@huyz Please reach out to Snyk Support on that, as it's an official channel providing customer support.

@michelkaporin michelkaporin requested review from Team-Hammerhead and a team August 7, 2023 08:59
@danacr
Copy link
Author

danacr commented Aug 7, 2023

@michelkaporin thank you for the feedback! I missed your comment, just regenerated everything

@michelkaporin michelkaporin removed their request for review August 28, 2023 07:02
@michelkaporin
Copy link
Contributor

@danacr @snyk/hammerhead should take care of your PR, as I moved to a different team at Snyk. I've pinged them to re-review it.

@wilson1000-MoJ
Copy link

Sorry to hijack this PR for my issue. I just don't see where to report problems for this repo.

Has anyone been able to get the snyk/snyk:python action to work? No matter what I do, I get:

`snyk` requires an authenticated account. Please run `snyk auth` and try again.

even though my SNYK_TOKEN secret is set in the repo and I have:

    steps:
      - uses: actions/checkout@v3
      - name: Run Snyk to check configuration files for security issues
        uses: snyk/actions/python@master
        # Snyk can be used to break the build when it detects security issues.
        # In this case we want to upload the issues to GitHub Code Scanning
        continue-on-error: true
        env:
          # In order to use the Snyk Action you will need to have a Snyk API token.
          # More details in https://github.com/snyk/actions#getting-your-snyk-token
          # or you can signup for free at https://snyk.io/login
          SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
        with:
          #args: --severity-threshold=high
          args: --sarif-file-output=snyk.sarif

This used to work months ago, but it's stopped working for months now. (And I'm wondering if Snyk has CI on their own actions 😄 )

I had the same issue and moved the SNYK_TOKEN to the global scope. It all worked after that.

@danacr danacr requested a review from a team as a code owner February 20, 2024 20:32
@danacr
Copy link
Author

danacr commented Feb 20, 2024

hey folks, can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants