Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade node-gyp in workflow actions #258

Merged
merged 7 commits into from
Mar 10, 2022
Merged

Upgrade node-gyp in workflow actions #258

merged 7 commits into from
Mar 10, 2022

Conversation

sebastianrath
Copy link
Contributor

@sebastianrath sebastianrath commented Mar 10, 2022 •
edited
Loading

node comes with its own node-gyp installation. GitHub recently upgraded their runners with VS2022 and the node-gyp that comes with Node 14 doesn't recognize the version. So we need to upgrade node-gyp in our workflow.

For more information see nodejs/node-gyp#2272
Also insightful: MadLittleMods/node-usb-detection#165

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1961074215

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 75.284%
Totals Coverage Status
Change from base Build 1874283201: -0.3%
Covered Lines: 1683
Relevant Lines: 2095
💛 - Coveralls

@coveralls
Copy link

coveralls commented Mar 10, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1961074215

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.0007%) to 77.581%
Totals Coverage Status
Change from base Build 1874283201: 2.0007%
Covered Lines: 1768
Relevant Lines: 2095
💛 - Coveralls

@sebastianrath sebastianrath merged commit 08b1cf1 into snowtrack:main Mar 10, 2022
@sebastianrath sebastianrath deleted the bugfix/issue-257 branch March 10, 2022 04:11
@MadLittleMods MadLittleMods mentioned this pull request Mar 10, 2022
Merged
@sebastianrath sebastianrath linked an issue Mar 10, 2022 that may be closed by this pull request
Update of windows-latest breaks workflow actions #257
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update of windows-latest breaks workflow actions
2 participants
@sebastianrath @coveralls