Added timestamp support #1884
Open
Added timestamp support #1884
+940
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-types # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/SimpleArrowFullVectorConverter.java
| private ValueVector vector; | ||
| private DataConversionContext context; | ||
| private TimeZone timeZoneToUse; | ||
| private boolean isNTZ; |
There was a problem hiding this comment.
IMO it would be better to have a boolean switched - isTZ. It seems that it would be more user-friendly as the timeZoneToUse is just next to the bool.
There was a problem hiding this comment.
isNTZ is used to distinguish between LTZ and NTZ cases - isTZ would be more confusing here I think. I'd go with just adding some comments here to clarify what these mean
| vector.allocateNew(length); | ||
| vector.setValueCount(length); | ||
| for (int i = 0; i < length; i++) { | ||
| vector.set(i, 1440); |
There was a problem hiding this comment.
How about defining the const for TZ offset?
| offsets.set( | ||
| i, | ||
| 1440 | ||
| + timeZone.getOffset(seconds.get(i) * 1000 + fractions.get(i) / 1000000) |
There was a problem hiding this comment.
Could we define & use consts for these calculations?
There was a problem hiding this comment.
Good catch, forgot to do that after initial testing
…e-types # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java # src/main/java/net/snowflake/client/jdbc/ArrowResultChunk.java
Base automatically changed from
arrow-batches-all-simple-types
to
SNOW-873466-arrow-batches
September 20, 2024 08:10
…stamps # Conflicts: # src/main/java/net/snowflake/client/core/arrow/fullvectorconverters/ArrowFullVectorConverter.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added tmestamp support
Pre-review self checklist
mvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX: