Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSTEVAL_* checks for non-decomposable expressions are not evaluated at compile time #145

Closed
cschreib opened this issue Nov 28, 2023 · 0 comments · Fixed by #146
Closed

CONSTEVAL_* checks for non-decomposable expressions are not evaluated at compile time #145

cschreib opened this issue Nov 28, 2023 · 0 comments · Fixed by #146
Assignees
@cschreib
Labels
bug:confirmed Something isn't working (confirmed)
Milestone
v1.2.4

Comments

@cschreib
Copy link
Member

The const here should have been constexpr:

snitch/include/snitch/snitch_macros_consteval.hpp

Line 22 in 770286e

const auto SNITCH_CURRENT_EXPRESSION = snitch::impl::expression{ \

@cschreib cschreib self-assigned this Nov 28, 2023
@cschreib cschreib added the bug:confirmed Something isn't working (confirmed) label Nov 28, 2023
@cschreib cschreib added this to the v1.2.4 milestone Nov 28, 2023
cschreib added a commit that referenced this issue Nov 28, 2023
@cschreib
Fix #145
9875972
@cschreib cschreib mentioned this issue Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cschreib cschreib

Labels
bug:confirmed Something isn't working (confirmed)
Projects
None yet
Milestone
v1.2.4
Development

Successfully merging a pull request may close this issue.

Fix consteval checks for non-decomposable expressions being evaluated at run time snitch-org/snitch
1 participant
@cschreib