Process timers set for exactly now
#73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug wherein the first timer set for exactly `now` ends up in the `pending` list instead of the `ready` list, eventually resulting in polling with a timeout of 0. Under normal circumstances this bug would trigger very rarely, and when it did would only result in one spurious "loop", since the next time the timers are checked, time will have advanced. However, this bug can cause misbehavior and deadlock in emulated environments. e.g., in the Shadow emulator, time only moves forward when a blocking syscall is performed, so this bug causes deadlock: https://gitlab.torproject.org/tpo/core/arti/-/issues/174#note_2762399
|
Thanks for the quick review and merge! |
|
Hi, is it possible to get a release, so that we can avoid a git-based dependency? |
|
Published in 1.7.0. |
Great, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug wherein the first timer set for exactly
nowends upin the
pendinglist instead of thereadylist, eventually resultingin polling with a timeout of 0.
Under normal circumstances this bug would trigger very rarely, and when
it did would only result in one spurious "loop", since the next time the
timers are checked, time will have advanced.
However, this bug can cause misbehavior and deadlock in emulated
environments. e.g., in the Shadow emulator, time only moves forward when
a blocking syscall is performed, so this bug causes deadlock:
https://gitlab.torproject.org/tpo/core/arti/-/issues/174#note_2762399