Optimize block_on by caching Parker and Waker #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notgull
reviewed
Sep 9, 2023
Inspired by what futures-lite does in its block_on impl
BigWingBeat
force-pushed
the
block_on_optimization
branch
from
b1f9bac
to
86b40aa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
async-io's implementation ofblock_oncurrently creates a new parker and waker on every invocation. This PR caches the parker and waker in a thread-local to improve performance. Most of this code is copied fromfutures-lite's implementation ofblock_on, as that crate already does exactly this, and the performance difference between these twoblock_onimplementations is why I looked into optimizingasync-ioin the first place.futures-lite (Red) vs async-io without this PR (Yellow)
futures-lite (Red) vs async-io with this PR (Yellow)
(Also see bevyengine/bevy#9626 for more context)