Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require non-empty aws.auth#sigv4 name #635

Merged
merged 1 commit into from
Nov 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/source/1.0/spec/aws/aws-auth.rst
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ Trait value
* - name
- ``string``
- **Required**. The signature version 4 service signing name to use
in the `credential scope`_ when signing requests. This value
SHOULD match the ``arnNamespace`` property of the
:ref:`aws.api#service-trait`.
in the `credential scope`_ when signing requests. This value MUST
NOT be empty. This value SHOULD match the ``arnNamespace`` property
of the :ref:`aws.api#service-trait`.

.. tabs::

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
"target": "smithy.api#String",
"traits": {
"smithy.api#required": {},
"smithy.api#length": {
"min": 1
},
"smithy.api#documentation": "The signature version 4 service signing name to use in the credential scope when signing requests. This value SHOULD match the `arnNamespace` property of the `aws.api#service-trait`.",
"smithy.api#externalDocumentation": {
"Reference": "https://docs.aws.amazon.com/general/latest/gr/sigv4-create-string-to-sign.html"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
[ERROR] smithy.example#InvalidService: Error validating trait `aws.auth#sigv4`.name: String value provided for `aws.auth#sigv4$name` must be >= 1 characters, but the provided value is only 0 characters. | TraitValue
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
namespace smithy.example

use aws.auth#sigv4

@sigv4(name: "")
service InvalidService {
version: "2020-07-02"
}