Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forward reference resolution of service shapes #543

Merged
merged 1 commit into from
Aug 26, 2020

Commits on Aug 26, 2020

  1. Fix forward reference resolution of service shapes

    Service shapes weren't correctly using forward reference resolution in
    the IDL for operation bindings and resource bindings. This is because we
    were eagerly taking the value out of a StringNode that uses a syntactic
    shape ID before all of the shapes are resolved. This causes the
    StringNode to assume that the shape ID is in the same namespace that it
    was defined in, which can be incorrect when there are `use` statements
    in effect. To address this, I've updated the optionalId and
    optionalIdList methods used in the IDL loader to always use a dedicated
    forward reference resolution callback independent of the callback used
    in other places (like trait values). Now things like identifiers,
    inputs, outputs, operation, and resource bindings are all handled in a
    uniform way.
    mtdowling committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    eb0b8dd View commit details
    Browse the repository at this point in the history