Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug allowing validation to be skipped #440

Merged
merged 2 commits into from
May 18, 2020
Merged

Fix bug allowing validation to be skipped #440

merged 2 commits into from
May 18, 2020

Commits on May 15, 2020

  1. Fix bug allowing validation to be skipped 

    This fixes a bug where any `SourceException`s rasied after the model
assembler began validation would result in validation getting
skipped. This was due to the fact that the assembler calls `onEnd`
in its visitor before validation AND whenever it catches that
class of exception. `onEnd` will cache its result, so you can't simply
call `onError` and guarantee it will be in the output.
    @JordonPhillips
    JordonPhillips committed May 15, 2020
    Configuration menu
    Copy the full SHA
    86199b0 View commit details
    Browse the repository at this point in the history

  2. Fix typo in suppress trait docs

    @JordonPhillips
    JordonPhillips committed May 15, 2020
    Configuration menu
    Copy the full SHA
    07fabc7 View commit details
    Browse the repository at this point in the history