Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify implementation of rendering prefix headers #1841

Merged

Commits on Oct 11, 2022

  1. Simplify implementation of rendering prefix headers

    The implementation that binds the target of
    `@httpPrefixHeaders`-annotated member shapes is overly complex in that
    it accounts for the possibility of it targeting a list shape. However,
    `@httpPrefixHeaders` can only be applied to structure members targeting
    map shapes:
    
    * https://awslabs.github.io/smithy/1.0/spec/core/http-traits.html#httpprefixheaders-trait
    * https://awslabs.github.io/smithy/2.0/spec/http-bindings.html#httpprefixheaders-trait
    
    The existing implementation likely came to be by copy-pasting the
    `RustWriter.renderHeaders` extension function.
    
    I've also taken the liberty of reformatting and renaming variables for
    clarity and consistency.
    david-perez committed Oct 11, 2022
    Configuration menu
    Copy the full SHA
    0f4cbf1 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Configuration menu
    Copy the full SHA
    f08ed26 View commit details
    Browse the repository at this point in the history