Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Net eight #2391

Merged
merged 18 commits into from
Aug 6, 2024
Merged

Net eight #2391

merged 18 commits into from
Aug 6, 2024

Conversation

trishorts
Copy link
Contributor

@trishorts trishorts commented Jul 29, 2024

Update MM to .Net 8.0 with accompanying changes to nuget packages and wix.
Changes to all .csproj files
Added Nunit legacy to avoid annoying changes that accompany Nunit updates.

The following were updated:
MathNet.Numerics.MKL.Win" Version="3.0.0"
Microsoft.ML" Version="3.0.1"
Microsoft.ML.CpuMath" Version="3.0.1"
Microsoft.ML.FastTree" Version="3.0.1"
Newtonsoft.Json" Version="13.0.3"
SharpLearning.CrossValidation" Version="0.31.8"
SharpLearning.GradientBoost" Version="0.31.8"
SharpLearning.Metrics" Version="0.31.8"
System.CodeDom" Version="8.0.0"
System.Collections.Immutable" Version="8.0.0"
System.Drawing.Common" Version="8.0.7"
System.Memory" Version="4.5.5"
System.Runtime.CompilerServices.Unsafe" Version="6.0.0"
System.Threading.Tasks.Dataflow" Version="8.0.1"

@trishorts trishorts added Packaging/Distributing Long-Term Stability Maintenance dependencies Pull requests that update a dependency file WIP Work in progress, not ready for review labels Jul 29, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.62%. Comparing base (4e95528) to head (bb008cf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2391   +/-   ##
=======================================
  Coverage   93.62%   93.62%           
=======================================
  Files         140      140           
  Lines       21891    21895    +4     
  Branches     3012     3005    -7     
=======================================
+ Hits        20495    20499    +4     
  Misses        937      937           
  Partials      459      459           
Files Coverage Δ
...etaMorpheus/GuiFunctions/MetaDraw/MetaDrawLogic.cs 95.63% <ø> (ø)
...ctions/MetaDraw/SpectrumMatch/SpectrumMatchPlot.cs 95.22% <ø> (ø)
...eus/TaskLayer/SearchTask/PostSearchAnalysisTask.cs 93.63% <100.00%> (+0.01%) ⬆️

... and 3 files with indirect coverage changes

@Alexander-Sol
Copy link
Contributor

image
This error gets thrown at the very end of tasks

@trishorts
Copy link
Contributor Author

image This error gets thrown at the very end of tasks

You might have an empty net6.0 folder in gui/bin/debug that is acting as bait. happens when you switch between versions. maybe you could look and delete and retry?
image

Copy link
Contributor

@Alexander-Sol Alexander-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In PeptideSpectralMatchTest, line 36 should be changed to string

pairedTargetDecoyHash = null;

to be compatible with the current master of mzLib

@elaboy
Copy link
Contributor

elaboy commented Aug 6, 2024

can you target both net 6.0 and net 8.0?

@nbollis nbollis merged commit 737823c into smith-chem-wisc:master Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Long-Term Stability Maintenance Packaging/Distributing WIP Work in progress, not ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants