Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delegate workflow spec creation #14365

Merged
merged 16 commits into from
Sep 17, 2024
Merged

Delegate workflow spec creation #14365

merged 16 commits into from
Sep 17, 2024

Conversation

nolag
Copy link
Contributor

@nolag nolag commented Sep 6, 2024

No description provided.

@nolag nolag force-pushed the rtinianov_delegateWorkflowSpec branch from 8170eef to 8f7fe59 Compare September 6, 2024 16:31
@nolag nolag force-pushed the rtinianov_delegateWorkflowSpec branch from 8f7fe59 to 398c760 Compare September 6, 2024 17:05
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

🎖️ No JIRA issue number found in: PR title, commit message, or branch name. Please include the issue ID in one of these.

@nolag nolag marked this pull request as ready for review September 16, 2024 15:28
@nolag nolag requested review from a team as code owners September 16, 2024 15:28
@nolag nolag requested review from patrickhuie19 and removed request for a team September 16, 2024 15:28
nolag
nolag commented Sep 16, 2024
View reviewed changes
core/scripts/go.mod Outdated Show resolved Hide resolved
bolekk
bolekk reviewed Sep 16, 2024
View reviewed changes
core/services/job/models.go Show resolved Hide resolved
core/services/job/models.go Outdated Show resolved Hide resolved
core/services/workflows/engine.go
@@ -853,7 +854,7 @@ func (e *Engine) Close() error {
}

type Config struct {
Spec string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Spec" feels OK, why the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it wasn't used and spec is't always going to be a string.

@nolag nolag requested review from yevshev and a team as code owners September 16, 2024 20:04
@nolag nolag force-pushed the rtinianov_delegateWorkflowSpec branch from b581fa6 to 99206f6 Compare September 17, 2024 13:59
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@nolag nolag requested a review from jmank88 September 17, 2024 16:59
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
85.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@nolag nolag added this pull request to the merge queue Sep 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 17, 2024
@jmank88 jmank88 added this pull request to the merge queue Sep 17, 2024
Merged via the queue into develop with commit a7348f0 Sep 17, 2024
136 of 137 checks passed
@jmank88 jmank88 deleted the rtinianov_delegateWorkflowSpec branch September 17, 2024 20:03
momentmaker added a commit that referenced this pull request Sep 19, 2024
@momentmaker
Merge branch 'develop' into re-2964/goreleaser-ccip
15cbe34 
* develop: (79 commits)
  core/config/toml: include value in InsecureConnection error message (#14495)
  vrf: add soneium config for integration tests (#14443)
  Add default test config for Grafana (#14475)
  Update to 1.5 RMN contract address (#14485)
  fix lint issues (#14450)
  [BCFR-203] Improve CR value comparator querying (topics and data words) by doing encoding in the relayer (#14207)
  integration-tests/deployment/ccip: fix assertion fns (#14482)
  chore: remove gha workflow validation (#14487)
  devsvcs-244: update token transfer (#14481)
  DF-20481: Add new OCR3DataFeeds telemetry type for Mercury jobs (#14470)
  Merc 6304 view function ea telem support (#14467)
  [DEVSVCS-545] cleanup (#14478)
  Mantle use vanilla l1 oracle (#14471)
  Fix E2E_TESTS_ON_GITHUB_CI.md (#14473)
  Upgrade chainlink ccip dependency (#14474)
  [DEVSVCS-545] automation benchmark test remove support for keepers v1 (#14472)
  Enables OOO Execution for E2E Tests (#14392)
  Delegate workflow spec creation (#14365)
  CCIP-3407: Add release testing configs (#1436) (#14463)
  Implement v0.3-compatible telemetry for LLO (#14440)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@cedric-cordenier cedric-cordenier cedric-cordenier approved these changes

@patrickhuie19 patrickhuie19 Awaiting requested review from patrickhuie19 patrickhuie19 is a code owner automatically assigned from smartcontractkit/foundations

@eutopian eutopian Awaiting requested review from eutopian eutopian is a code owner

@yevshev yevshev Awaiting requested review from yevshev yevshev is a code owner

@bolekk bolekk Awaiting requested review from bolekk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nolag @jmank88 @bolekk @cedric-cordenier @skudasov