Core changes for changing Execute Capability API to sync #14317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ettec
force-pushed
the
callback-capability-api-spike
branch
5 times, most recently
from
9fc444a
to
7ee01e0
Compare
ettec
requested review from
EasterTheBunny,
DeividasK and
cedric-cordenier
and removed request for
a team
ettec
changed the title
|
If you format your PR links as list items, then we can see their status: Requires: |
ettec
force-pushed
the
callback-capability-api-spike
branch
2 times, most recently
from
f4d630a
to
b71c775
Compare
cedric-cordenier
previously approved these changes
Sep 6, 2024
ettec
force-pushed
the
callback-capability-api-spike
branch
2 times, most recently
from
082da7c
to
81d88a6
Compare
ettec
force-pushed
the
callback-capability-api-spike
branch
from
199aaae
to
d0c511c
Compare
|
cedric-cordenier
approved these changes
Sep 6, 2024
jmank88
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Execute Capability API from Async to sync. https://smartcontract-it.atlassian.net/browse/CAPPL-27
As its used right now, in all places, callers of the API expect one result and block on the channel to wait for that single result, i.e.they are effectively sync calls. Moving to a sync API will improve the capability developer experience and protect against bugs where the capability developer sends more that one result or forgets to close the channel (for example this would break current remote target implementation). This does not preclude adding an additional Async capability type in future should the need arise.
Requires: