Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check to not fetch mercury prices when trigger capability is enabled #13888

Merged
merged 23 commits into from
Sep 17, 2024
Merged

Added check to not fetch mercury prices when trigger capability is enabled #13888

merged 23 commits into from
Sep 17, 2024
+127 −19

Conversation

karen-stepanyan
Copy link
Contributor

@karen-stepanyan karen-stepanyan commented Jul 18, 2024 •
edited by jira bot
Loading

DF-20169

Added new check in Observe method in core/services/relay/evm/mercury/v3/data_source.go file that extracts the EnableTriggerCapability boolean from dataSource and if true skips calling LatestPrice function. For Data Feeds 2.0 with DON - DON communication we don't need to fetch any price info from mercury server

@karen-stepanyan karen-stepanyan requested a review from a team July 18, 2024 14:02
@karen-stepanyan karen-stepanyan changed the title add check to not fetch mercury prices when trigger capability is enabled Added check to not fetch mercury prices when trigger capability is enabled Jul 18, 2024
@karen-stepanyan karen-stepanyan requested a review from a team as a code owner July 18, 2024 14:23
samsondav
samsondav previously approved these changes Jul 18, 2024
View reviewed changes
austinborn
austinborn approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@austinborn austinborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you

austinborn
austinborn previously approved these changes Jul 18, 2024
View reviewed changes
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
1 New issue
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@austinborn austinborn requested a review from a team as a code owner September 15, 2024 21:36
@austinborn austinborn requested a review from a team as a code owner September 16, 2024 10:21
@austinborn austinborn requested review from samsondav and a team September 16, 2024 18:06
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
10.3% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

samsondav
samsondav approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit of a hack, but then the entire plugin basically is one so 🤷‍♂️

@austinborn austinborn added this pull request to the merge queue Sep 17, 2024
Merged via the queue into develop with commit 37c5a2f Sep 17, 2024
136 of 137 checks passed
@austinborn austinborn deleted the feature/DF-20169 branch September 17, 2024 13:32
@github-actions github-actions bot mentioned this pull request Sep 17, 2024
Draft
@austinborn
Copy link
Collaborator

Bit of a hack, but then the entire plugin basically is one so 🤷‍♂️

Thank you, since we're planning to move to the LLO plugin at some point I felt more comfortable taking this approach.

@austinborn austinborn mentioned this pull request Sep 19, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsondav samsondav samsondav approved these changes

@austinborn austinborn austinborn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karen-stepanyan @austinborn @samsondav