[KS-372] Lazy initialize the registrysyncer #13787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
ks-372-no-live-nodes-registrysyncer
branch
from
ae24258
to
72d2111
Compare
krehermann
reviewed
Jul 9, 2024
| stopCh services.StopChan | ||
| launchers []Launcher | ||
| reader types.ContractReader | ||
| initReader func(ctx context.Context, lggr logger.Logger, relayer contractReaderFactory, registryAddress string) (types.ContractReader, error) |
There was a problem hiding this comment.
/nit: it doesn't seem like this can be set by any caller. iiuc, then there would be less indirection to simply make it a static method on the syncer, or omit it entirely and call newReader in it's place
There was a problem hiding this comment.
I added this mainly to make testing easier, such that a test could set initReader and set up a mock rather than setting up an actual chain reader.
krehermann
approved these changes
Jul 9, 2024
ettec
approved these changes
Jul 9, 2024
This was referenced Jul 17, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires Dependencies
Resolves Dependencies