Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCI-3381] Implement GetTransactionStatus for the EVM ChainWriter. #13691

Merged
merged 4 commits into from
Jun 26, 2024
Merged

[BCI-3381] Implement GetTransactionStatus for the EVM ChainWriter. #13691

merged 4 commits into from
Jun 26, 2024

Conversation

nickcorin
Copy link
Contributor

  • evm: Implement get transaction status
  • evm: Implement get transaction status

Requires Dependencies

Resolves Dependencies

@nickcorin nickcorin requested a review from a team as a code owner June 25, 2024 15:01
jmank88
jmank88 previously approved these changes Jun 25, 2024
View reviewed changes
@nickcorin nickcorin requested a review from jmank88 June 25, 2024 15:42
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

patrick-dowell
patrick-dowell approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@patrick-dowell patrick-dowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to see E2E tests for this one. Although given that this functionality is just a passthrough for the logic that Amit wrote in the TXM, his unit tests in the TXM also help verify that this functionality works properly.

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Jun 26, 2024
Merged via the queue into develop with commit f2630b2 Jun 26, 2024
113 checks passed
@prashantkumar1982 prashantkumar1982 deleted the feat/cw-tx-status branch June 26, 2024 01:32
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrick-dowell patrick-dowell patrick-dowell approved these changes

@silaslenihan silaslenihan silaslenihan approved these changes

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@amit-momin amit-momin amit-momin approved these changes

@jmank88 jmank88 Awaiting requested review from jmank88

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickcorin @jmank88 @patrick-dowell @silaslenihan @prashantkumar1982 @amit-momin